Solved progress display error while navigating from payment tab in delivery progress screen #3257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…livery progress screen
shubham1g5
reviewed
Jul 18, 2025
| @Override | ||
| public void onResume() { | ||
| super.onResume(); | ||
| binding.getRoot().requestLayout(); |
Contributor
There was a problem hiding this comment.
@Jignesh-dimagi can you proide a technical description of the root cause in the PR description along with how this fixes this issue.
Contributor
Author
There was a problem hiding this comment.
@shubham1g5 There seems some issue with ViewPager2 in calculating the dynamic height after the data are reloaded, it requires some kind of recalculation, may be this is the one way to do that. This works here but not sure if this is the best way.
Contributor
There was a problem hiding this comment.
ok, can we add a code comment here for this, for someone looking at this code to know this is due to a viewpager 2 bug and if we remove it what exactly should we be testing to make sure the removal is safe.
shubham1g5
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
https://dimagi.atlassian.net/browse/QA-7923
Labels and Review