Fixes for French #3191
Fixes for French #3191
Conversation
… text is wide). Added some missing translations. Shortened one French translation.
📝 WalkthroughWalkthroughThis change updates several resource files in the Android project. The layout file for phone verification was simplified by removing an extra LinearLayout wrapper and adjusting the layout parameters and margins of two TextViews. French localization strings were updated: one string was shortened, and two new strings were added for UI elements related to facial image capture and demo user phone verification skipping. Additionally, a new string for "micro_image_activity_title" was added in Portuguese, Swahili, and Tigrinya localization files, providing translated titles for a facial image capture activity. Possibly related PRs
Suggested reviewers
✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
app/res/layout/screen_personalid_phone_verify.xml (2)
34-42: Ensure phone number overflow is handled
Usingwrap_contentwithout ellipsizing may cause very long phone numbers to overflow. Consider adding:android:maxLines="1" android:ellipsize="end"to
@+id/connect_phone_verify_labelor switch tomatch_parentwith weight and ellipsize.
44-53: Add vertical spacing between label and link
With both TextViews in a vertical layout and nolayout_marginTop, they’ll render flush together. Consider:<TextView android:id="@+id/connect_phone_verify_change" … + android:layout_marginTop="8dp" android:text="@string/connect_verify_phone_change" … />to improve readability.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
app/res/layout/screen_personalid_phone_verify.xml(1 hunks)app/res/values-fr/strings.xml(3 hunks)app/res/values-pt/strings.xml(1 hunks)app/res/values-sw/strings.xml(1 hunks)app/res/values-ti/strings.xml(1 hunks)
🔇 Additional comments (6)
app/res/values-ti/strings.xml (1)
540-540: Add Tigrinya translation for facial capture title
The newmicro_image_activity_titlestring aligns with other locales and follows naming conventions.app/res/values-pt/strings.xml (1)
556-556: Add Portuguese translation for facial capture title
TheCapturar Imagem Facialentry correctly implements the newmicro_image_activity_titleresource and matches other language files.app/res/values-sw/strings.xml (2)
541-541: Verify locale‐wide consistency for new string
Themicro_image_activity_titlekey appears only in Swahili. Ensure this string is also added to your defaultvalues/strings.xml(and any other missing locales) to prevent missing-resource errors at runtime.
Run:rg -n "micro_image_activity_title" -e "app/res/values/strings.xml"
541-541: Approve Swahili translation
“Piga Picha ya Uso” accurately conveys “Capture face photo” and aligns with other locales.app/res/values-fr/strings.xml (2)
511-511: Approve shortened confirmation string
Changing “Demander plus tard” to “Plus tard” preserves meaning while improving fit in UI.
585-585: Approve demo-user OTP skip message
The newconnect_verify_skip_phone_numberstring clearly explains skipping OTP for demo accounts. Translation reads well.
| <string name="download_app">Télécharger</string> | ||
| <string name="progress">Progrès</string> | ||
| <string name="sync">Synchroniser</string> | ||
| <string name="micro_image_activity_title">Capturer Photo Visage</string> |
There was a problem hiding this comment.
Improve French translation for facial capture title
“Capturer Photo Visage” is literal and sounds unnatural. Recommend “Prendre une photo du visage” or “Capturer une photo du visage”.
Would you like me to propose the exact diff?
🤖 Prompt for AI Agents
In app/res/values-fr/strings.xml at line 539, the French translation for the
facial capture title is too literal and unnatural. Replace "Capturer Photo
Visage" with a more natural phrase such as "Prendre une photo du visage" or
"Capturer une photo du visage" to improve readability and user experience.
Addressing observations 2, 3, 4, and 5 here:
https://dimagi.atlassian.net/browse/QA-7847
Arranged "change phone" link below phone text (to avoid overflow when text is wide).
Added some missing translations.
Shortened one French translation.