-
-
Notifications
You must be signed in to change notification settings - Fork 45
Added the french localisation as per the sheet #3120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThe changes consist of a comprehensive update to the French localization file Sequence Diagram(s)No sequence diagram is generated for this change, as it consists solely of updates to localization string resources without modifications to control flow or feature logic. Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure ✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🧹 Nitpick comments (2)
app/res/values-fr/strings.xml (2)
41-41: Use consistent positional placeholders.The message
multiple_apps_limit_messageuses%sfor dynamic values. For better clarity and to follow Android best practices, switch to numbered placeholders (%1$s,%2$s):-<string name="multiple_apps_limit_message">…vous ne pouvez avoir que %s applications…</string> +<string name="multiple_apps_limit_message">…vous ne pouvez avoir que %1$s applications…</string>
93-96: Consolidate duplicate “Annuler” strings.The entries
cancel,cancel_loading_form,cancel_location, andcancel_saving_formall share the same translated value (“Annuler”). Consider defining a single<string name="cancel">Annuler</string>and reusing it via@string/cancelto reduce duplication and simplify future updates.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
app/res/values-fr/strings.xml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Lint Code Base
🔇 Additional comments (1)
app/res/values-fr/strings.xml (1)
14-609: Great work on the comprehensive French localization update.The file has been significantly expanded with accurate translations, new keys for application management, error reporting, ConnectID flows, and more. This will meaningfully enhance the French user experience.
app/res/values-fr/strings.xml
Outdated
| <string name="expirenotification">Connexion CommCare expirée</string> | ||
| <string name="submission_notification_title">Soumission de données</string> | ||
| <string name="submission_logs_title">Soumission des journaux CommCare</string> | ||
| #VALUE! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove invalid placeholder.
The line containing #VALUE! is not a valid XML element and will break resource compilation. Please remove this stray placeholder or replace it with a properly formatted <string> entry.
🤖 Prompt for AI Agents
In app/res/values-fr/strings.xml at line 59, there is an invalid placeholder
`#VALUE!` that is not a valid XML element and will cause resource compilation
errors. Remove this line entirely or replace it with a correctly formatted
<string> element containing the intended translation text.
| <string name="manager_activity_name">Gestionnaire d\'applications</string> | ||
| <string name="install_app">Installer une application</string> | ||
| <string name="uninstall_app">Désinstaller</string> | ||
| <string name="archive_app">Archive</string> | ||
| <string name="unarchive_app">Désarchiver</string> | ||
| <string name="update_app">Mise à jour</string> | ||
| <string name="update_canceled">Votre mise à jour a été suspendue</string> | ||
| <string name="update_pinned_notification">Téléchargement de la mise à jour</string> | ||
| <string name="verify_resources">Valider le multimédia</string> | ||
| <string name="skip_button_text">Passer pour l\'instant</string> | ||
| <string name="retry_button_text">Réessayer</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace backslash-escaped apostrophes with proper characters.
Strings like Gestionnaire d\'applications and Passer pour l\'instant include literal backslashes (\’) which will be displayed in the UI. Use either a plain apostrophe (') or the XML entity ' instead. This pattern repeats elsewhere in the file; please audit all occurrences.
🤖 Prompt for AI Agents
In app/res/values-fr/strings.xml between lines 16 and 26, replace all
backslash-escaped apostrophes (\' ) with proper apostrophes by either using a
plain apostrophe (') or the XML entity '. Review the entire file for
similar occurrences and correct them to prevent literal backslashes from
appearing in the UI.
| <string name="completed_data">Complet (%s)</string> | ||
| <string name="data">Formulaires sauvegardés</string> | ||
| <string name="change_language">Changer de langue</string> | ||
| <string name="clearanswer_confirm">Supprimer la réponse à \%s\"?"</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Fix malformed XML in formatted string.
The entry for clearanswer_confirm currently contains \%s\"?", which is neither valid XML nor a proper format placeholder. Escape quotes correctly (e.g., ") and use a positional placeholder. For example:
-<string name="clearanswer_confirm">Supprimer la réponse à \%s\"?"</string>
+<string name="clearanswer_confirm">Supprimer la réponse à %1$s ?</string>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <string name="clearanswer_confirm">Supprimer la réponse à \%s\"?"</string> | |
| <string name="clearanswer_confirm">Supprimer la réponse à %1$s ?</string> |
🤖 Prompt for AI Agents
In app/res/values-fr/strings.xml at line 102, the string for clearanswer_confirm
contains malformed XML with incorrect escaping of the percent sign and quotes.
Fix this by replacing the backslash before %s with a proper format placeholder
%s, and escape the double quote using " to ensure valid XML syntax and
correct string formatting.
Product Description
French translation added from sheet
Technical Summary
https://dimagi.atlassian.net/browse/CCCT-1264
Labels and Review