Skip to content

Conversation

@Jignesh-dimagi
Copy link
Contributor

@Jignesh-dimagi Jignesh-dimagi commented May 21, 2025

Product Description

French translation added from sheet

Technical Summary

https://dimagi.atlassian.net/browse/CCCT-1264

Labels and Review

  • Do we need to enhance the manual QA test coverage ? If yes, the "QA Note" label is set correctly
  • Does the PR introduce any major changes worth communicating ? If yes, the "Release Note" label is set and a "Release Note" is specified in PR description.
  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@coderabbitai
Copy link

coderabbitai bot commented May 21, 2025

📝 Walkthrough

Walkthrough

The changes consist of a comprehensive update to the French localization file strings.xml used by the application. Numerous existing translations have been revised for improved clarity, accuracy, and consistency. Many new string resources have been added, covering areas such as application management, media verification, migration errors, privilege claiming, recovery mode, notification channels, and expanded ConnectID features including login, registration, recovery, verification, messaging, and payment confirmation. The update also introduces new and revised strings for form handling, media attachments, location services, user interaction, and error reporting, resulting in a significantly expanded and modernized French language resource set.

Sequence Diagram(s)

No sequence diagram is generated for this change, as it consists solely of updates to localization string resources without modifications to control flow or feature logic.

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

✨ Finishing Touches
🧪 Generate Unit Tests
  • Create PR with Unit Tests
  • Commit Unit Tests in branch jignesh/fr_localisation
  • Post Copyable Unit Tests in Comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🧹 Nitpick comments (2)
app/res/values-fr/strings.xml (2)

41-41: Use consistent positional placeholders.

The message multiple_apps_limit_message uses %s for dynamic values. For better clarity and to follow Android best practices, switch to numbered placeholders (%1$s, %2$s):

-<string name="multiple_apps_limit_message">…vous ne pouvez avoir que %s applications…</string>
+<string name="multiple_apps_limit_message">…vous ne pouvez avoir que %1$s applications…</string>

93-96: Consolidate duplicate “Annuler” strings.

The entries cancel, cancel_loading_form, cancel_location, and cancel_saving_form all share the same translated value (“Annuler”). Consider defining a single <string name="cancel">Annuler</string> and reusing it via @string/cancel to reduce duplication and simplify future updates.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fefe117 and 93f7ef3.

📒 Files selected for processing (1)
  • app/res/values-fr/strings.xml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Lint Code Base
🔇 Additional comments (1)
app/res/values-fr/strings.xml (1)

14-609: Great work on the comprehensive French localization update.

The file has been significantly expanded with accurate translations, new keys for application management, error reporting, ConnectID flows, and more. This will meaningfully enhance the French user experience.

<string name="expirenotification">Connexion CommCare expirée</string>
<string name="submission_notification_title">Soumission de données</string>
<string name="submission_logs_title">Soumission des journaux CommCare</string>
#VALUE!
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Remove invalid placeholder.

The line containing #VALUE! is not a valid XML element and will break resource compilation. Please remove this stray placeholder or replace it with a properly formatted <string> entry.

🤖 Prompt for AI Agents
In app/res/values-fr/strings.xml at line 59, there is an invalid placeholder
`#VALUE!` that is not a valid XML element and will cause resource compilation
errors. Remove this line entirely or replace it with a correctly formatted
<string> element containing the intended translation text.

Comment on lines +16 to +26
<string name="manager_activity_name">Gestionnaire d\'applications</string>
<string name="install_app">Installer une application</string>
<string name="uninstall_app">Désinstaller</string>
<string name="archive_app">Archive</string>
<string name="unarchive_app">Désarchiver</string>
<string name="update_app">Mise à jour</string>
<string name="update_canceled">Votre mise à jour a été suspendue</string>
<string name="update_pinned_notification">Téléchargement de la mise à jour</string>
<string name="verify_resources">Valider le multimédia</string>
<string name="skip_button_text">Passer pour l\'instant</string>
<string name="retry_button_text">Réessayer</string>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Replace backslash-escaped apostrophes with proper characters.

Strings like Gestionnaire d\'applications and Passer pour l\'instant include literal backslashes (\’) which will be displayed in the UI. Use either a plain apostrophe (') or the XML entity &apos; instead. This pattern repeats elsewhere in the file; please audit all occurrences.

🤖 Prompt for AI Agents
In app/res/values-fr/strings.xml between lines 16 and 26, replace all
backslash-escaped apostrophes (\' ) with proper apostrophes by either using a
plain apostrophe (') or the XML entity &apos;. Review the entire file for
similar occurrences and correct them to prevent literal backslashes from
appearing in the UI.

<string name="completed_data">Complet (%s)</string>
<string name="data">Formulaires sauvegardés</string>
<string name="change_language">Changer de langue</string>
<string name="clearanswer_confirm">Supprimer la réponse à \%s\"?"</string>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Fix malformed XML in formatted string.

The entry for clearanswer_confirm currently contains \%s\"?", which is neither valid XML nor a proper format placeholder. Escape quotes correctly (e.g., &quot;) and use a positional placeholder. For example:

-<string name="clearanswer_confirm">Supprimer la réponse à \%s\"?"</string>
+<string name="clearanswer_confirm">Supprimer la réponse à %1$s ?</string>
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<string name="clearanswer_confirm">Supprimer la réponse à \%s\"?"</string>
<string name="clearanswer_confirm">Supprimer la réponse à %1$s ?</string>
🤖 Prompt for AI Agents
In app/res/values-fr/strings.xml at line 102, the string for clearanswer_confirm
contains malformed XML with incorrect escaping of the percent sign and quotes.
Fix this by replacing the backslash before %s with a proper format placeholder
%s, and escape the double quote using &quot; to ensure valid XML syntax and
correct string formatting.

@shubham1g5 shubham1g5 added the skip-integration-tests Skip android tests. label May 21, 2025
@Jignesh-dimagi Jignesh-dimagi merged commit 19a21e2 into master May 22, 2025
6 checks passed
@Jignesh-dimagi Jignesh-dimagi deleted the jignesh/fr_localisation branch May 22, 2025 05:25
@coderabbitai coderabbitai bot mentioned this pull request Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-integration-tests Skip android tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants