Reduce code verbosity of forms #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxammann
approved these changes
Jan 9, 2023
There was a problem hiding this comment.
Looks good, I did a quick review of the code and a smoke test.
Maybe some minor thing we can do in this PR: I would propose to make the "Ich beantrage neben der physischen auch die digitale Ehrenamtskarte." opt-out so it is by default selected.
I think most people would like one but maybe dont set it because they dont know what it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces code verbosity for forms by introducing utility functions for compound forms.
(
This was a bit of a fun side project to get to know typescript better^^. My typescript wishlist:
microsoft/TypeScript#12936
and
microsoft/TypeScript#14466
)