-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1672: Improve birthday field #1767
base: 1670-show-form-hints
Are you sure you want to change the base?
Conversation
const { viewportSmall } = useWindowDimensions() | ||
const formStyle = viewportSmall ? { fontSize: 16, padding: '9px 10px' } : { fontSize: 14, padding: '6px 10px' } | ||
const textFieldBoxShadow = | ||
'0 0 0 0 rgba(205, 66, 70, 0), 0 0 0 0 rgba(205, 66, 70, 0), inset 0 0 0 1px #cd4246, inset 0 0 0 1px rgba(17, 20, 24, 0.2), inset 0 1px 1px rgba(17, 20, 24, 0.3)' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just copy the box shadow from the standard TextField components of MUI.
If someone know how to improve that, just let me know
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on firefox, works great 🎉
<DesktopDatePicker | ||
views={['year', 'month', 'day']} | ||
value={date} | ||
format='dd.MM.yyyy' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ How does this correspond with the LocalizationProvider
you wrapped the app in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This library needs the Localization provider you can check the documentation
bbdf70f
to
ca0080a
Compare
Short description
As a koblenz pass applicant i want to provide my birthday easily on a mobile device
Proposed changes
Note
Side effects
Testing
Resolved issues
Fixes: #1672