Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade validation warnings to errors flag #19259

Merged
merged 11 commits into from
Jul 10, 2024
Merged

Upgrade validation warnings to errors flag #19259

merged 11 commits into from
Jul 10, 2024

Commits on May 28, 2024

  1. Split errors into errors that can turn into warnings (or vice versa)

    @dylant-da
    dylant-da committed May 28, 2024
    Configuration menu
    Copy the full SHA
    cd426f5 View commit details
    Browse the repository at this point in the history

  2. Add warn-bad-interface-instances flag

    @dylant-da
    dylant-da committed May 28, 2024
    Configuration menu
    Copy the full SHA
    9642e1b View commit details
    Browse the repository at this point in the history

  3. fix compilation errors, finish implementation of swap

    @dylant-da
    dylant-da committed May 28, 2024
    Configuration menu
    Copy the full SHA
    c32977c View commit details
    Browse the repository at this point in the history

  4. Add tests for warn-bad-interface-instances flag

    @dylant-da
    dylant-da committed May 28, 2024
    Configuration menu
    Copy the full SHA
    783728f View commit details
    Browse the repository at this point in the history

  5. Bump - try to rebuild? 

    run-all-tests: true
    @dylant-da
    dylant-da committed May 28, 2024
    Configuration menu
    Copy the full SHA
    572f119 View commit details
    Browse the repository at this point in the history

  6. Don't do single-package checks if typecheck-upgrades: true

    @dylant-da
    dylant-da committed May 28, 2024
    Configuration menu
    Copy the full SHA
    4d02b07 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Fix tests that break on warn-bad-interface-instances

    @dylant-da
    dylant-da committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    2662ac4 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. Lint

    @dylant-da
    dylant-da committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    7173442 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Move WEWarningToError to Error type, remove commented code 

    Also:
- Mark integration tests as flaky again
- Whitespace
    @dylant-da
    dylant-da committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    ca465fc View commit details
    Browse the repository at this point in the history

  2. Check errors & warns aren't emitted when upgrades/typechecking disabled

    @dylant-da
    dylant-da committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    e78ef35 View commit details
    Browse the repository at this point in the history

  3. Update error message & expected error message

    @dylant-da
    dylant-da committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    1ec643d View commit details
    Browse the repository at this point in the history