Upgrade validation warnings to errors flag #19259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylant-da
force-pushed
the
upgrade-validation-warnings-to-errors-flag
branch
from
3923696
to
77fd53a
Compare
run-all-tests: true
dylant-da
force-pushed
the
upgrade-validation-warnings-to-errors-flag
branch
from
54d5842
to
4d02b07
Compare
samuel-williams-da
approved these changes
Jul 8, 2024
sdk/compiler/damlc/daml-opts/daml-opts-types/DA/Daml/Options/Types.hs
Outdated
Show resolved
Hide resolved
sdk/daml-assistant/integration-tests/src/DA/Daml/Assistant/IntegrationTests.hs
Outdated
Show resolved
Hide resolved
Also: - Mark integration tests as flaky again - Whitespace
dylant-da
added a commit
that referenced
this pull request
Jul 10, 2024
dylant-da
added a commit
that referenced
this pull request
Jul 10, 2024
dylant-da
force-pushed
the
upgrade-validation-warnings-to-errors-flag
branch
from
d3864b7
to
1ec643d
Compare
samuel-williams-da
approved these changes
Jul 10, 2024
dylant-da
added a commit
that referenced
this pull request
Jul 10, 2024
* Expand upgrade validation testing (#19123) * Remove duplication from tests * lint * lint * Simplify tests * lint * add more tests for dependency behaviour * track new test files * lint * add test for failure being only emitted in the module that originates it * fix stdout capture for rules_daml * lint * lint * Move CannotUpgradeView into own section * Fix more upgrades gen * Fix build issues with test-common upgrades files * Backport changes from #19259 * Add back agreement warning test * Lint * Fix reference from 2.dev to 1.dev * Fix upgrade test files * Revert stdout from daml_compile in daml.bzl * Fix reference in IntegrationTests * Fix trigger tests to ignore interface/template upgrade errors * Only run upgrade checks when building with a supporting LF version * Fix MissingModule test for participant upgrade check tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns interface warnings into errors, provides flag to downgrade them.
Before we do this for expressions, we need to fix expression errors to be less eager.
In the long term I'd like a similar system to that for GHC, where we can downgrade most errors to warnings and upgrade most warnings to errors