refactor: 🏷️ Make data-size and data-color behave more predictable
#2951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3e31922 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Preview deployments for this pull request: Storybook - |
mimarz
changed the title
data-size and data-color propsdata-size and data-color attributes behave the same
mimarz
changed the title
data-size and data-color attributes behave the samedata-size and data-color behave more predictable
mimarz
force-pushed
the
feat-loosen-data-types
branch
from
d5eca33 to
70d8e79
Compare
Barsnes
reviewed
Jan 7, 2025
Barsnes
reviewed
Jan 7, 2025
Barsnes
reviewed
Jan 8, 2025
Barsnes
approved these changes
Jan 8, 2025
Barsnes
pushed a commit
that referenced
this pull request
Jan 8, 2025
#2951) - Made it so `data-size` and `data-color` also accept any string as default so its the same as behaviour for other data attributes. - Except for explicits components - Removed references and default values for `data-size` and `data-color` in stories as thats contextual. - Removed unnecessary override to `data-size` and `data-color` to make sure the jsdocs and behaviour is uniform. - Added `data-color` and `data-size` as global `argTypes` for storybook so that they show up in controls for all components
Barsnes
pushed a commit
that referenced
this pull request
Jan 8, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to next, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `next` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `next`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @digdir/designsystemet@1.0.0-next.45 ### Minor Changes - Fix wrong base default color beeing set by the themebuilder ([#2953](#2953)) - Moved typography based sizing formula to design-tokens ([#2796](#2796)) - Removed design-tokens `sizing` & `spacing`, use `size`. ([#2939](#2939)) - Support for building typography based sizing design-tokens ([#2796](#2796)) ### Patch Changes - Rename `data-ds-typography` to `data-typography` ([#2959](#2959)) ## @digdir/designsystemet-css@1.0.0-next.45 ### Minor Changes - Removed CSS variables `--ds-spacing-*` & `--ds-sizing-*`, use `--ds-size-*`. ([#2939](#2939)) - New CSS variables for sizes, `--ds-size-*` ([#2935](#2935)) - Moved typography based sizing formula to design-tokens ([#2796](#2796)) ### Patch Changes - Button: add `height: fit-content` ([#2942](#2942)) - Pagination: Use empty `li` for ellipsis ([#2942](#2942)) - Link: Fix missing underline when using Tailwind ([#2923](#2923)) - Table: ([#2933](#2933)) - Correct footer styling - Automatic focus styling for sorting buttons - Switch: Adjust design to better align with radio and checkbox ([#2929](#2929)) - Tooltip: Use popover API ([#2916](#2916)) - Removes `delay`, this is now `--dsc-tooltip-transition-delay` - Removes `defaultOpen` - Removes `portal` - Removes ability to hover to keep open - PopoverTrigger: New prop `inline` for use when inline elements (such as text) need a `Popover` ([#2915](#2915)) ## @digdir/designsystemet-theme@1.0.0-next.45 ### Minor Changes - Removed CSS variables `--ds-spacing-*` & `--ds-sizing-*`, use `--ds-size-*`. ([#2939](#2939)) - Moved typography based sizing formula to design-tokens ([#2796](#2796)) - Removed design-tokens `sizing` & `spacing`, use `size`. ([#2939](#2939)) ### Patch Changes - Rename `data-ds-typography` to `data-typography` ([#2959](#2959)) ## @digdir/designsystemet-react@1.0.0-next.45 ### Patch Changes - Pagination: Use empty `li` for ellipsis ([#2942](#2942)) - Add missing `data-size` and `data-color` props to Details ([#2930](#2930)) - Table: ([#2933](#2933)) - Correct footer styling - Automatic focus styling for sorting buttons - Loosen default types for `data-color` and `data-size` to support accept `string` ([#2951](#2951)) - Export all utilities ([#2961](#2961)) - Field: Fix `position` not working ([#2931](#2931)) - Tooltip: Use popover API ([#2916](#2916)) - Removes `delay`, this is now `--dsc-tooltip-transition-delay` - Removes `defaultOpen` - Removes `portal` - Removes ability to hover to keep open - PopoverTrigger: New prop `inline` for use when inline elements (such as text) need a `Popover` ([#2915](#2915)) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2943
data-sizeanddata-coloralso accept any string as default so its the same as behaviour for other data attributes.data-sizeanddata-colorin stories as thats contextual.data-sizeanddata-colorto make sure the jsdocs and behaviour is uniform.data-coloranddata-sizeas globalargTypesfor storybook so that they show up in controls for all components