Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Switch): adjust design #2929

Merged
merged 4 commits into from
Dec 20, 2024
Merged

fix(Switch): adjust design #2929

merged 4 commits into from
Dec 20, 2024

Conversation

eirikbacker
Copy link
Contributor

@eirikbacker eirikbacker commented Dec 20, 2024 •
edited
Loading

@eirikbacker eirikbacker self-assigned this Dec 20, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 20, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 428823b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@digdir/designsystemet-css Patch
@digdir/designsystemet Patch
@digdir/designsystemet-theme Patch
@digdir/designsystemet-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 20, 2024 •
edited
Loading

Preview deployments for this pull request:

Storybook - 20. Dec 2024 - 13:53

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 20, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 55.2% 3198 / 5793
🔵 Statements 55.2% 3198 / 5793
🔵 Functions 86.6% 181 / 209
🔵 Branches 76.96% 518 / 673
File CoverageNo changed files found.
Generated in workflow #1384 for commit 428823b by the Vitest Coverage Report Action

@eirikbacker eirikbacker marked this pull request as ready for review December 20, 2024 11:56
Barsnes
Barsnes reviewed Dec 20, 2024
View reviewed changes
packages/css/src/input.css Outdated Show resolved Hide resolved
@Barsnes
Copy link
Member

Barsnes commented Dec 20, 2024

It looks like this is missing the lock icon when in read-only mode, but this is also the case for Checkbox and Radio, so I suggest we solve all of those in a separate PR after this
image

@eirikbacker
Copy link
Contributor Author

eirikbacker commented Dec 20, 2024 •
edited
Loading

It looks like this is missing the lock icon when in read-only mode, but this is also the case for Checkbox and Radio, so I suggest we solve all of those in a separate PR after this.

Yeah, talked to @Febakke about this, as radio/checkbox does not have lock right now, we await doing it for Switch too. He has texted Altinn Studio (who use a lot of readonly and switch) and asked about their opinion. Supporting doing this in another PR if it turns out to be something we want :)

@Barsnes
Copy link
Member

Barsnes commented Dec 20, 2024

It looks like this is missing the lock icon when in read-only mode, but this is also the case for Checkbox and Radio, so I suggest we solve all of those in a separate PR after this.

Yeah, talked to @Febakke about this, as radio/checkbox does not have lock right now, we await doing it for Switch too. He has texted Altinn Studio (who use a lot of readonly and switch) and asked about their opinion. Supporting doing this in another PR if it turns out to be something we want :)

Great. If this needs investegating, do we have an issue, or should one be made?

@eirikbacker eirikbacker merged commit da5696a into next Dec 20, 2024
10 checks passed
@eirikbacker eirikbacker deleted the fix/switch-adjustments branch December 20, 2024 12:56
@github-actions github-actions bot mentioned this pull request Dec 20, 2024
Merged
Barsnes pushed a commit that referenced this pull request Jan 8, 2025
@github-actions
chore: new release candidate (next) (#2922)
1424d5d 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to next, this PR will
be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`next` is currently in **pre mode** so this branch has prereleases
rather than normal releases. If you want to exit prereleases, run
`changeset pre exit` on `next`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## @digdir/designsystemet@1.0.0-next.45

### Minor Changes

- Fix wrong base default color beeing set by the themebuilder
([#2953](#2953))

- Moved typography based sizing formula to design-tokens
([#2796](#2796))

- Removed design-tokens `sizing` & `spacing`, use `size`.
([#2939](#2939))

- Support for building typography based sizing design-tokens
([#2796](#2796))

### Patch Changes

- Rename `data-ds-typography` to `data-typography`
([#2959](#2959))

## @digdir/designsystemet-css@1.0.0-next.45

### Minor Changes

- Removed CSS variables `--ds-spacing-*` & `--ds-sizing-*`, use
`--ds-size-*`.
([#2939](#2939))

- New CSS variables for sizes, `--ds-size-*`
([#2935](#2935))

- Moved typography based sizing formula to design-tokens
([#2796](#2796))

### Patch Changes

- Button: add `height: fit-content`
([#2942](#2942))

- Pagination: Use empty `li` for ellipsis
([#2942](#2942))

- Link: Fix missing underline when using Tailwind
([#2923](#2923))

-   Table: ([#2933](#2933))

    -   Correct footer styling
    -   Automatic focus styling for sorting buttons

- Switch: Adjust design to better align with radio and checkbox
([#2929](#2929))

- Tooltip: Use popover API
([#2916](#2916))

    -   Removes `delay`, this is now `--dsc-tooltip-transition-delay`
    -   Removes `defaultOpen`
    -   Removes `portal`
    -   Removes ability to hover to keep open

- PopoverTrigger: New prop `inline` for use when inline elements (such
as text) need a `Popover`
([#2915](#2915))

## @digdir/designsystemet-theme@1.0.0-next.45

### Minor Changes

- Removed CSS variables `--ds-spacing-*` & `--ds-sizing-*`, use
`--ds-size-*`.
([#2939](#2939))

- Moved typography based sizing formula to design-tokens
([#2796](#2796))

- Removed design-tokens `sizing` & `spacing`, use `size`.
([#2939](#2939))

### Patch Changes

- Rename `data-ds-typography` to `data-typography`
([#2959](#2959))

## @digdir/designsystemet-react@1.0.0-next.45

### Patch Changes

- Pagination: Use empty `li` for ellipsis
([#2942](#2942))

- Add missing `data-size` and `data-color` props to Details
([#2930](#2930))

-   Table: ([#2933](#2933))

    -   Correct footer styling
    -   Automatic focus styling for sorting buttons

- Loosen default types for `data-color` and `data-size` to support
accept `string`
([#2951](#2951))

- Export all utilities
([#2961](#2961))

- Field: Fix `position` not working
([#2931](#2931))

- Tooltip: Use popover API
([#2916](#2916))

    -   Removes `delay`, this is now `--dsc-tooltip-transition-delay`
    -   Removes `defaultOpen`
    -   Removes `portal`
    -   Removes ability to hover to keep open

- PopoverTrigger: New prop `inline` for use when inline elements (such
as text) need a `Popover`
([#2915](#2915))

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Barsnes Barsnes Barsnes approved these changes

@mimarz mimarz Awaiting requested review from mimarz mimarz is a code owner

@unekinn unekinn Awaiting requested review from unekinn

Assignees

@eirikbacker eirikbacker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch adjustments
2 participants
@eirikbacker @Barsnes