Skip to content

Change libraries #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Conversation

Sparks29032
Copy link
Collaborator

Use Pytest instead of UnitTest, use importlib instead of pkg_resources (deprecated).

@Sparks29032 Sparks29032 reopened this Jul 19, 2023
@Sparks29032
Copy link
Collaborator Author

Seeing if we can move away from pkg_resouces. Use importlib.resources instead. Note importlib_resources does not work for some reason.

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #83 (05443de) into main (6fdf12b) will increase coverage by 4.11%.
The diff coverage is 81.73%.

@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
+ Coverage   75.01%   79.13%   +4.11%     
==========================================
  Files          36       36              
  Lines        1437     1615     +178     
==========================================
+ Hits         1078     1278     +200     
+ Misses        359      337      -22     
Impacted Files Coverage Δ
diffpy/pdfmorph/tests/test_pdfplot.py 100.00% <ø> (ø)
diffpy/pdfmorph/pdfplot.py 8.27% <9.09%> (+0.16%) ⬆️
diffpy/pdfmorph/pdfmorphapp.py 56.37% <56.56%> (+29.10%) ⬆️
diffpy/pdfmorph/__init__.py 100.00% <100.00%> (ø)
diffpy/pdfmorph/tests/test_morphchain.py 100.00% <100.00%> (ø)
diffpy/pdfmorph/tests/test_morphpdftordf.py 100.00% <100.00%> (ø)
diffpy/pdfmorph/tests/test_morphrdftopdf.py 100.00% <100.00%> (ø)
diffpy/pdfmorph/tests/test_morphresolution.py 100.00% <100.00%> (ø)
diffpy/pdfmorph/tests/test_morphrgrid.py 100.00% <100.00%> (ø)
diffpy/pdfmorph/tests/test_morphscale.py 100.00% <100.00%> (ø)
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sbillinge
Copy link
Contributor

Seeing if we can move away from pkg_resouces. Use importlib.resources instead. Note importlib_resources does not work for some reason.

Thanks for this. Have you googled around about this? I had a conversation with Tom Caswell and he said that this change in python broke many things and all kinds of upstream packages have to make these changes. I guess if we are using pkg_resources it would be good to fix this too, but maybe reach out to him if it is not discussed fully in your google searches.....

@Sparks29032
Copy link
Collaborator Author

Changes merged to PR #82, branch no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants