-
Notifications
You must be signed in to change notification settings - Fork 18
Rename PDF-specific smear option to --smear-pdf
#220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #220 +/- ##
==========================================
+ Coverage 97.36% 97.44% +0.08%
==========================================
Files 20 20
Lines 947 978 +31
==========================================
+ Hits 922 953 +31
Misses 25 25
🚀 New features to boost your workflow:
|
@Sparks29032 I am afraid this one has a conflict. |
Ah, probably from me fixing a typo on another PR. Should be resolved now. |
[ | ||
"--smear", | ||
"100", | ||
"--smear-pdf", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code block also tests the default behavior if a user inputs both morphs. The pdf smear takes precedence.
I am merging this. I had one comment which is to please make all new tests as pytest tests, not unittest tests. We would gradually over time like to migrate back to pytest tests entirely, but at least, let's not make new unittest tests. |
Thanks for merging! I thought these tests were already migrated from unittest to Pytest in #83. These tests seem to follow the Pytest documentation. |
maybe I didn't check well enough. It looked as if it was indented and part of a class and not a standalone function. |
They are classes, but I thought this is supported and encouraged by https://docs.pytest.org/en/stable/getting-started.html. I think I need the python tests presentation lol. |
Ah, I see. I don't really see any benefit unless tests are sharing a bunch of code or marks, but mostly I just assumed they were unittest tests (which are typically the only tests we write in classes.....) |
Closes #210.
The
--smear-pdf
option first converts the PDF to an RDF before applying the smear. The--smear
option does not do such transformation. If both are enabled, the--smear-pdf
option takes precedence.