Skip to content

Remove the removeFormat method (fixes #653) #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Remove the removeFormat method (fixes #653) #979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions plugin-gradle/CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ We adhere to the [keepachangelog](https://keepachangelog.com/en/1.0.0/) format (

## [Unreleased]

### Removed
* **BREAKING** `removeFormat` (which has been broken since `5.0`) has been removed. Use `clearSteps()` as a workaround ([#653](https://github.com/diffplug/spotless/issues/653)).

## [5.17.1] - 2021-10-26
### Changed
* Added support and bump Eclipse formatter default versions to `4.21` for `eclipse-groovy`. Change is only applied for JVM 11+.
Expand Down
9 changes: 0 additions & 9 deletions plugin-gradle/src/main/java/com/diffplug/gradle/spotless/SpotlessExtension.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,15 +182,6 @@ public void format(String name, Action<FormatExtension> closure) {
format(name, FormatExtension.class, closure);
}

/** Makes it possible to remove a format which was created earlier. */
public void removeFormat(String name) {
requireNonNull(name);
FormatExtension toRemove = formats.remove(name);
if (toRemove == null) {
project.getLogger().warn("Called removeFormat('" + name + "') but there was no such format.");
}
}

boolean enforceCheck = true;

/** Returns {@code true} if Gradle's {@code check} task should run {@code spotlessCheck}; {@code false} otherwise. */
Expand Down