Remove the removeFormat method (fixes #653)
#979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Released in plugin-gradle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removeFormathas been broken since5.0, and there is an easy workaround withclearSteps()(#653). This PR removes the broken method.This is a breaking change (kinda, it's been accidentally broken for a long time). I'm putting this PR in the queue now because there are probably some smallish breaking changes on the way which are needed to resolve the dependency resolution weirdness that we've been struggling with for a long time. Since a
6.0is on the way soon anyway, now is a good time to pile-in on any lingering debt.