-
Couldn't load subscription status.
- Fork 1
Add CI and swift-format config #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1371c7e to
ce9b64e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I tend to agree to those initial formatting rules. Fine to change some if we ever run into anything particular of course.
Might have to disable the macOS tests for now since they will either make the job fail or won't do anything since everything is commented out by #ifdef canImport(_Differentiation)
|
Also let's copy this config over to the other repos once we have agreed on these and this is merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I don't have enough experience writing swift to be opinionated on style (except no hard tabs, ever), so happy to go with your recommendations
- I agreed having
-Werrorfrom the start is a good idea - We should be able the make a template repository so we don't have to manually copy and paste to each new repo
|
I'd like to add this rule in a next PR any thoughts @GNMoseke?
Or do we do this by hand for now? |
Depends on #1
This adds basic CI (linting and tests on macOS/ubuntu) for PRs. Some things to keep in mind:
.swift-formatfile here is opinionated based on my personal preferences, I am happy to tweak them based on other maintainers' thoughts-Werroras I think it's a good practice to get into off the starting block. Again, if we forsee unavoidable errors (@deprecated()😡 ) being added, happy to remove those flags