CI: set up linting #6
Conversation
JaapWijnen
force-pushed
the
ci/set-up-linting-and-tests
branch
3 times, most recently
from
29a8f5d to
9a548c5
Compare
JaapWijnen
force-pushed
the
ci/set-up-linting-and-tests
branch
2 times, most recently
from
aa3382c to
eff5d52
Compare
JaapWijnen
force-pushed
the
ci/set-up-linting-and-tests
branch
from
eff5d52 to
71d828b
Compare
JaapWijnen
force-pushed
the
ci/set-up-linting-and-tests
branch
from
71d828b to
3977333
Compare
|
This unfortunately contains some bugs wrt Differentiation (see some of the lint fails) where it "corrects" correct spelling to something that doesn't compile. It tries to remove spaces in a spot that leads to concatenating two unrelated tokens. |
|
I think we'll have to switch to Nick Lockwood's formatter. That way we can also define a custom rule that allows _vjp spelling for functions which I'd like to do. Haven't found a way for custom rules in apple's swift-format yet. |
|
Nice. We should probably add a comment why we're disabling swift-format for those files and link to the issue once we have created one |
GNMoseke
force-pushed
the
ci/set-up-linting-and-tests
branch
from
824ab19 to
34e20fc
Compare
|
I've overhauled this branch to use Nick's SwiftFormat - PRs coming to other repos as well In the long term I'd still like to use the apple one just to keep our dependencies completely clean, but it is definitely not ready for primetime yet |
|
bump @clackary @JaapWijnen |
GNMoseke
force-pushed
the
ci/set-up-linting-and-tests
branch
from
34e20fc to
6588538
Compare
GNMoseke
force-pushed
the
ci/set-up-linting-and-tests
branch
2 times, most recently
from
83c5eff to
5b03001
Compare
GNMoseke
force-pushed
the
ci/set-up-linting-and-tests
branch
from
5b03001 to
88b3532
Compare
Depends on #8
Same implementation as differentiable-swift/swift-numerics-differentiable#2
except for also adding the
NoAccessLevelOnExtensionDeclarationrule here. Which we should update in the other repos as well.