feat: add in existing code #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This copies in parts of our existing Differentiation library code. No tests yet since those are written using XCTest will add those in a separate MR.
JaapWijnen
force-pushed
the
feat/add-existing-code
branch
from
198dae6 to
127c881
Compare
|
Why add tests as their own PR? My personal vote would be just to convert them directly to swift-testing as part of this MR and then add new checks/behavior tweaks in follow-ons |
|
Yeah sorry, actually decided as follow on commits to do the refactor that is needed and provide tests as well. Just as separate commits so the history shows what the code was before we moved it over. |
…eView This is required for our implementation of min/max vjps on sequences/collections
We should look at these in a future iteration
These vjps are now defined in the standard library
|
This one is best reviewed per commit :) Some commits paste in old code. From our internal module. Others then improve on that code etc etc. @clackary @GNMoseke @tmcdonell |
Merged
clackary
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This copies in parts of our existing Differentiation library code. No tests yet since those are written using XCTest will add those in a separate MR.