Skip to content

Upgrade to Doxyen 1.8.16 #5058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 23, 2019
Merged

Conversation

thk123
Copy link
Contributor

@thk123 thk123 commented Aug 23, 2019

This is exactly @owen-jones-diffblue PR (#5047) but with the whitespace trimming in the warning file removed.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • [n.a] The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • [n/a] Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • [na] My commit message includes data points confirming performance improvements (if claimed).
  • [na] My PR is restricted to a single feature or bugfix.
  • [na] White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Owen added 4 commits August 22, 2019 13:02
The old version is no longer available from this host
The new version of Doxygen seems to have slightly different warnings
We used to check that we got exactly "1.8.14", but now we get
"1.8.16 (b4ba8f5*)", so we just check
that it starts with "1.8.16".
These tags are no longer used by doxygen
Copy link
Contributor

@chrisr-diffblue chrisr-diffblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - but seeing as there are a reasonably large number of new Doxygen warnings, it might be worth raising that as a documentation issue to be fixed at some point.

@thk123
Copy link
Contributor Author

thk123 commented Aug 23, 2019

For visibility, as requested by Chris R, I've raised 🔒 DOC-173 to track fixing these warnings

@codecov-io
Copy link

Codecov Report

Merging #5058 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5058   +/-   ##
========================================
  Coverage    69.56%   69.56%           
========================================
  Files         1314     1314           
  Lines       108922   108922           
========================================
  Hits         75776    75776           
  Misses       33146    33146

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9284ae...8844fa5. Read the comment docs.

@kroening kroening merged commit b8302cf into diffblue:develop Aug 23, 2019
@thk123 thk123 deleted the upgrade-doxygen-2 branch August 23, 2019 14:27
This was referenced Aug 23, 2019
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 8844fa5).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/124383440

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants