Skip to content

Update Doxygen version #5047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Update Doxygen version #5047

wants to merge 4 commits into from

Conversation

owen-mc-diffblue
Copy link
Contributor

The old version is no longer available from this host

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

thk123
thk123 approved these changes Aug 22, 2019
View reviewed changes
Copy link
Contributor

@thk123 thk123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't imagine point releases mattering.

Is wget-ing from this serve the best option?

chrisr-diffblue
chrisr-diffblue approved these changes Aug 22, 2019
View reviewed changes
Copy link
Contributor

@chrisr-diffblue chrisr-diffblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that a minor point release update doesn't break CI doxygen, approved. Depending on how much we want to tie ourselves to a specific Doxygen version it might be better to host the chosen version ourselves - but I don't think the download links have broken very often, so might not be worth the extra management.

chrisr-diffblue
chrisr-diffblue approved these changes Aug 22, 2019
View reviewed changes
Copy link
Contributor

@chrisr-diffblue chrisr-diffblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that a minor point release update doesn't break CI doxygen, approved. Depending on how much we want to tie ourselves to a specific Doxygen version it might be better to host the chosen version ourselves - but I don't think the download links have broken very often, so might not be worth the extra management.

@owen-mc-diffblue owen-mc-diffblue force-pushed the update-doxygen-version branch 2 times, most recently from 349a04f to 2f9afc0 Compare August 22, 2019 11:54
Update Doxygen version
92da8b3 
The old version is no longer available from this host
@owen-mc-diffblue owen-mc-diffblue force-pushed the update-doxygen-version branch 2 times, most recently from 26bd645 to fa8af91 Compare August 22, 2019 12:26
@owen-mc-diffblue owen-mc-diffblue force-pushed the update-doxygen-version branch 2 times, most recently from 7cd46cd to 918b1cb Compare August 22, 2019 14:04
@owen-mc-diffblue
Copy link
Contributor Author

I'm having problems with multi-line doxygen warnings. They seemed to work before.

Owen added 3 commits August 22, 2019 15:19
Update expected warnings
f631765 
The new version of Doxygen seems to have slightly different warnings
Change how we check doxygen version
5d7afc1 
We used to check that we got exactly "1.8.14", but now we get
"1.8.16 (b4ba8f5*)", so we just check
that it starts with "1.8.16".
Remove tags that are no longer needed from doxyfile
be679f7 
These tags are no longer used by doxygen
@allredj allredj mentioned this pull request Aug 22, 2019
Merged
7 tasks
This was referenced Aug 22, 2019
Closed
Merged
@thk123
Copy link
Contributor

thk123 commented Aug 23, 2019

Replaced by #5058

@thk123 thk123 closed this Aug 23, 2019
@owen-mc-diffblue owen-mc-diffblue deleted the update-doxygen-version branch August 27, 2019 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smowton smowton smowton approved these changes

@thk123 thk123 thk123 approved these changes

@chrisr-diffblue chrisr-diffblue chrisr-diffblue approved these changes

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel is a code owner

@kroening kroening Awaiting requested review from kroening kroening is a code owner

@tautschnig tautschnig Awaiting requested review from tautschnig tautschnig is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@owen-mc-diffblue @thk123 @smowton @chrisr-diffblue