Apache HTTP Client 5 implementation #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rameter in the config is false
* cached queries will be sent with fixed-sizes request * requests of cached queries will be cached as well (addresses #223)
This was
linked to
issues
Feb 16, 2024
bigerl
requested changes
Feb 20, 2024
There was a problem hiding this comment.
Thx for the PR. This looks overall sound but could use some more documentation here and there.
Find my specific comments and remarks below.
Please also review the usage of the apache http client5 with respect to refactoring, simplifying the code, extracting classes to separate files and documentation. Currently, the usage is a but hard to follow.
src/main/java/org/aksw/iguana/cc/utils/http/StreamEntityProducer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/aksw/iguana/cc/utils/http/StreamEntityProducer.java
Outdated
Show resolved
Hide resolved
bigerl
requested changes
Feb 22, 2024
src/main/java/org/aksw/iguana/cc/worker/impl/SPARQLProtocolWorker.java
Outdated
Show resolved
Hide resolved
bigerl
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the Apache HTTP Client 5 for the query executions. This should improve the performance of Iguana.
Also changes following things:
parseResultsis turned off, received response bodies from HTTP requests won't be hashed anymore, to improve performance