Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the option to URL-encode every query string before the benchmark execution #223

Closed
nck-mlcnv opened this issue Oct 24, 2023 · 0 comments · Fixed by #243
Closed

Add the option to URL-encode every query string before the benchmark execution #223

nck-mlcnv opened this issue Oct 24, 2023 · 0 comments · Fixed by #243
Labels
enhancement

Comments

@nck-mlcnv
Copy link
Contributor

nck-mlcnv commented Oct 24, 2023 •
edited
Loading

As the title says. If the RequestFactory is supposed to create URL-Encoded http request, the query strings don't need to be reencoded every single time the request is created. For this we should also add an additional option for the configuration file.
@nck-mlcnv nck-mlcnv changed the title Add the option to URL-encode every query request before the benchmark execution Add the option to URL-encode every query string before the benchmark execution Oct 24, 2023
nck-mlcnv added a commit that referenced this issue Feb 16, 2024
@nck-mlcnv
Change RequestFactory behavior
d9190cb 
* cached queries will be sent with fixed-sizes request
* requests of cached queries will be cached as well (addresses #223)
@nck-mlcnv nck-mlcnv mentioned this issue Feb 16, 2024
Merged
@nck-mlcnv nck-mlcnv linked a pull request Feb 16, 2024 that will close this issue
Apache HTTP Client 5 implementation #243
Merged
nck-mlcnv added a commit that referenced this issue Feb 23, 2024
@nck-mlcnv
Apache HTTP Client 5 implementation (#243)
a92d239 
* Add more logging messages

* Fix log4j2 configuration

* Implement apache HTTP client

* Implement apache HTTP async client 5

* Fix timeout

* Fixes

* Fix hashing bug

* Fix conversion of byte stream to string

* Implement POST request streaming

* Disable the storing and hashing of responses when the parseResults parameter in the config is false

* Move utility classes

* StreamEntityProducer can send fixed-sized data and is reproducible now

* Make QueryHandler return stream supplier and info about query being cached

* Change RequestFactory behavior

* cached queries will be sent with fixed-sizes request
* requests of cached queries will be cached as well (addresses #223)

* Cleanup

* Preload requests

* Fix IDE warnings

* Fix tests

* Remove unneeded test class

* Add Javadocs

* Change requests

* Move the RequestFactory to a separate class and add comments

* Add comments from overridden methods

* Lower maximum capacity while reading response
nck-mlcnv added a commit that referenced this issue Jul 25, 2024
@nck-mlcnv @bigerl
Add support for ahead-of-time compilation (#248)
1f4bb16 
* Add more logging messages

* Fix log4j2 configuration

* Implement apache HTTP client

* Implement apache HTTP async client 5

* Fix timeout

* Fixes

* Fix hashing bug

* Fix conversion of byte stream to string

* Implement POST request streaming

* Disable the storing and hashing of responses when the parseResults parameter in the config is false

* Move utility classes

* StreamEntityProducer can send fixed-sized data and is reproducible now

* Make QueryHandler return stream supplier and info about query being cached

* Change RequestFactory behavior

* cached queries will be sent with fixed-sizes request
* requests of cached queries will be cached as well (addresses #223)

* Cleanup

* Preload requests

* Fix IDE warnings

* Fix tests

* Remove unneeded test class

* Add Javadocs

* Add the GraalVM native-maven-plugin for ahead-of-time compilation

* Switch to Logback implementation of SLF4J, as Log4j2 is not supported with GraalVM

* Update native-maven-plugin version

* Native-image builder optimizations

* Remove pre-made graalvm config

* Update native profile

* Catch exceptions inside TriplestoreStorage

* Reset workerId after warmup

* Update native image plugin configuration

* Add scripts for working with native images

* Remove spring

* Rename directory

* Add test workflow

* Fix permissions

* Remove periods

* Fix script

* Fix workflow

* Update workflow

* Test directory upload

* Update workflows

* Update Test Workflow

* Fix workflow

* Another fix

* Rename job

* Remove test workflow

* Make workerID go out of scope

* Add comment for registering LanguageProcessors

* Clean up logging config

* Fix deploy workflow

* Disable non supported tests

* Update pom.xml to automatically generate configuration files for native image

* Update workflows

* Update documentation

* Fix symlink

* Add cpu micro architectures

* Add cpu micro architectures 2

* Update generate-config.sh

* Fix unstable tests

* Fix regex cleanup

* Enable long running tests on environment variable

* Increase the thread count for the apache http client

* Disable re-usage of bbaos and create bbaos of optimal size when possible

* Try to fix something

* Debug logging

* Debug logging 2

* Attempt to fix something

* Attempt to fix something 2

* Attempt to fix something 3

* Attempt to fix something 4

* Attempt to fix something 5

* Attempt to fix something 6

* Make thread dump

* Make thread dump 2

* Attempt to fix something 7

* Attempt to fix something 8

* Attempt to fix something 9

* Attempt to fix something 10

* Attempt to fix something 11

* Finetuning test

* Finetuning test 2

* Cleanup httpclient configuration

* Cleanup tests

* Disable compressed references by default

This option needs be set before compilation and it allows the heap to use more than 32gb.

* Remove test configurations

* Re-enable configurations and decrease timeout in tests

* Add workaround for failing tests

* Adjust test configurations

* Adjust test configurations 2

* Adjust test configurations 3

* Adjust test configurations 4

* Revert "Adjust test configurations 4"

This reverts commit 9bf8cc8.

* Shorten http client configuration

* Add ByteArrayList output and inputstream

* Update SPARQLProtocolWorker to use ByteArrayListOutputStream when response body has unknown length

* Fix bad merge conflict resolve

* Fix size calculation in ByteArrayListOutputStream

* Add test + fix for ByteArrayListInputStream

* Add test for ByteArrayListOutputStream

* Change single log message

* Update exception handling in TriplestoreStorage

* Add execution parameter to configuration generation

* Fix dry-run parameter

* Add comment in TriplestoreStorage

* Change behavior of ByteArrayListInputStream

* Add comments and access modifiers

* Update src/main/java/org/aksw/iguana/cc/storage/impl/TriplestoreStorage.java

Co-authored-by: Alexander Bigerl <bigerl@mail.upb.de>

* Update github workflow

---------

Co-authored-by: Alexander Bigerl <bigerl@mail.upb.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apache HTTP Client 5 implementation dice-group/IGUANA
1 participant
@nck-mlcnv