Skip to content

feat(headerbar): fix locale handling #1707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat(headerbar): fix locale handling #1707

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion components/header-bar/src/header-bar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,30 @@ export const HeaderBar = ({
}))
}, [data, baseUrl])

// sources
// 1. App Platform: /adapter/src/utils/localeUtils.js#L15
// 2. https://developer.mozilla.org/en-US/docs/Glossary/BCP_47_language_tag
const parseLocale = (locale) => {
const [language, region, script] = locale.split('_')

let languageTag = language
if (script) {
languageTag += `-${script}`
}
if (region) {
languageTag += `-${region}`
}
return new Intl.Locale(languageTag)
}

// See https://jira.dhis2.org/browse/LIBS-180
if (!loading && !error) {
// TODO: This will run every render which is probably wrong!
// Also, setting the global locale shouldn't be done in the headerbar
const locale = data.user.settings.keyUiLocale || 'en'

// ensures the locale/variant is separated by hyphens before being passed to changeLanguage
const locale =
parseLocale(data.user.settings.keyUiLocale)?.baseName || 'en'
i18n.setDefaultNamespace('default')
i18n.changeLanguage(locale)
}
Expand Down
Loading