feat(headerbar): fix locale handling #1707
Conversation
|
|
🚀 Deployed on https://pr-1707--dhis2-ui.netlify.app |
There was a problem hiding this comment.
So this would be perfect... if DHIS2 locale handling made sense 😅 instead, it's currently going the "wrong way"
--> Our input is either pt-BR (BCP-47, v42+) or pt_BR (Java .toString, <v42), and our output needs to be pt_BR (the Java.toString format) for the transifex files we have
P.S., testing can be confusing: it seems that if you set i18n.changeLanguage('pt-BR'), something works in a way that it falls back to pt -- I can tell since I looked at the translations in pt_BR.po and pt.po, and some strings are not translated for pt_BR, like "Search for apps". When using pt-BR as the language, though, "Search for apps" is translated, so it must be getting that from the pt.po file (since we don't have the fallback logic here yet)
I think adding this function can sort everything out: https://github.com/dhis2/app-platform/blob/master/adapter/src/utils/localeUtils.js#L59
Implements LIBS-798
Description
The previous implementation does not parse the locales with variants well enough to trigger the relevant change in language in the UI. When we pass a
keyUILocalethat is a language variant, saypt_BRdirectly toi18n.changeLanguage, it will not be picked up and the UI defaults toEnglish.In this implementation, we parse locales using the same functionality in the app platform's adapter. It reformats the locale to follow the BCP 47 syntax. For example,
pt_Brbecomespt-Brwhich triggers the translation.Checklist
All points above should be relevant for feature PRs. For bugfixes, some points might not be relevant. In that case, just check them anyway to signal the work is done.
Screenshots
For 'pt_Br'
