Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get event.resource by removing stage from route.path #1142

Merged

Conversation

matt-peck
Copy link
Contributor

See:
#1137
#1137 (comment)

That PR broke path parameters.
This PR fixes that issue and still sovles the need to remove stage from path for event.resource

@kerbe
Copy link

kerbe commented Jan 20, 2021

If this fixes these path parameters:
path in line 190
resourcePath in line 196
Both inside requestContext.
Then this is exactly what has caused problems for my coding past few days. I updated from 5.12.1 to 6.8.0, and things broke down in local development.

Any chances these gets merged & bugfix release done anytime soon? Is there something else that needs to be done to get this merged @dherault as this is quite critical showstopper right now?

@frozenbonito
Copy link
Contributor

Thank you @matt-peck.
This PR will also fix broken tests.

There are still be issue about event.resouce (#1029 (comment)), I will try to fix it.

@frozenbonito frozenbonito merged commit 430d97e into dherault:master Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants