Lambda-Event-Path-and-Resource-Sync #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ely removing the stage variable from resource
dherault
approved these changes
Dec 9, 2020
|
Thanks @matt-peck, will be included with the next version! |
|
@dherault Awesome! Thank you so much! |
|
@dherault I was helping some devs set this up locally this morning and discovered that this breaks path parameters because this.#path specifies the actual path parameter value where as route.path specifies the parameter variable. I added the change here: https://github.com/matt-peck/serverless-offline/blob/Lambda-Event-Path-And-Resource-Sync/src/events/http/lambda-events/LambdaProxyIntegrationEvent.js Line 131 and 200. How should I submit this, a new PR? |
This was referenced May 22, 2021
Open
This was referenced Jun 23, 2021
1 task
This was referenced Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change LambdaProxyIntegrationEvent returned resource to use non-stagePrepended URL from instance #path intead of route.path.
Motivation and Context
When running serverless-offline locally, the LambdaProxyIntegrationEvent uses the route.path to define the event.resource instead of this.#path. When using stages prepended to URLs to keep in step with a multi-environment local development setup (i.e. multiple environments tested with Postman), it is desirable to have the stage prepend the endpoint URL, but not desirable for the stage to mutate the event.resource where router / controller logic is determined.
Fixes: #1029
How Has This Been Tested?
Ran AWS Lambdas locally with URLs prepended by Stage with Postman.