Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(proposals): Incremental proposal key for zero proposals (#8005) #8567

Merged
merged 24 commits into from
Feb 8, 2023
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
62cef52
fix(proposals): Incremental proposal key for zero proposals (#8005)
all-seeing-code Sep 2, 2021
c697086
fix: fixing audit logs for websocket connections (#8048) (#8053) (#8627)
all-seeing-code Jan 24, 2023
84dbff5
fix(restore): consider the banned namespaces while bumping (#7839) (#…
mangalaman93 Jan 25, 2023
d5c5ffd
fix(sec): CVE-2022-41721 (#8633)
skrdgraph Jan 28, 2023
f92c578
fix(sec): CVE & OS Patching (#8634)
skrdgraph Jan 30, 2023
651d888
fix(backup): create directory before writing backup (#8638)
mangalaman93 Jan 30, 2023
3239462
temp commit
all-seeing-code Jan 31, 2023
752def6
chore(ci): update readme (#8632)
joshua-goldstein Jan 30, 2023
5148c95
fix(mutation): validate mutation before applying it (#8623)
mangalaman93 Jan 31, 2023
9aa7b9a
fix(groot): do not upsert groot for all namespaces on restart (#8561)
mangalaman93 Feb 1, 2023
e32548c
remove comments
all-seeing-code Feb 2, 2023
9a8a598
fix(tests): Added Backup/Restore test for NFS. (#8551)
shivaji-dgraph Feb 1, 2023
ff8fe2a
fix(restore): Set kv version to restoreTs for all keys (#7930) (#8563)
mangalaman93 Feb 2, 2023
65eb7a7
fix(probe): do not contend for lock in lazy load (#8037) (#8041) (#8566)
mangalaman93 Feb 2, 2023
2ae33e2
Add a test that after snapshot is applied, GraphQL schema is refreshe…
shivaji-dgraph Feb 2, 2023
b70d235
bug(core): Fixed infinite loop in CommitToDisk (#8614)
harshil-goel Feb 2, 2023
7443a10
Store namespace in predicate as a hex separated by a hyphen to preven…
harshil-goel Feb 3, 2023
1558efd
fix(proposalKey): Proposal key initialisation with correct byte order…
all-seeing-code Feb 6, 2023
cd759d7
wrap the functions
all-seeing-code Feb 7, 2023
6499c3f
fix(build): Update dockerfile to use cache busting and reduce image s…
all-seeing-code Feb 7, 2023
5573b56
fix test failures
all-seeing-code Feb 7, 2023
365cca5
fix imports
all-seeing-code Feb 7, 2023
3246cbd
chore(deps): update min go build version (#8423)
joshua-goldstein Feb 7, 2023
af9398f
Merge branch 'main' into anurag/cherry-pick-proposal-fix
all-seeing-code Feb 8, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(probe): do not contend for lock in lazy load (#8037) (#8041) (#8566)
Earlier the admin server mutex lock was used to protect the graphql
schema map. But now we store that in schema store that internally
handles the concurrency. Hence, we don't need to take the admin server's
read lock to access schema.

/probe/graphql is used as health check and is called very frequently.
This rlock on adminserver mutex makes the /probe/graphql requests block
while lazy loading when restore operation gets triggered at the startup.
That leads to so many go routines being spun up.

(cherry picked from commit 5ad40d8)
  • Loading branch information
mangalaman93 authored and all-seeing-code committed Feb 8, 2023
commit 65eb7a7c15eddc17c2fc446d892e02c8bf7fc81f
3 changes: 0 additions & 3 deletions graphql/admin/admin.go
Original file line number Diff line number Diff line change
Expand Up @@ -1026,12 +1026,9 @@ func (as *adminServer) resetSchema(ns uint64, gqlSchema schema.Schema) {

func (as *adminServer) lazyLoadSchema(namespace uint64) error {
// if the schema is already in memory, no need to fetch it from disk
as.mux.RLock()
if currentSchema, ok := as.gqlSchemas.GetCurrent(namespace); ok && currentSchema.Loaded {
as.mux.RUnlock()
return nil
}
as.mux.RUnlock()

// otherwise, fetch the schema from disk
sch, err := getCurrentGraphQLSchema(namespace)
Expand Down