fix(probe): do not contend for lock in lazy load (#8037) (#8041) #8566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangalaman93
requested review from
akon-dey,
MichelDiz and
matthewmcneely
as code owners
|
|
mangalaman93
added
the
slash-to-main
|
@mangalaman93 It would be helpful to add a link to the PR which changes the graphql schema store in the PR description to verify this. |
|
That change is there in part of the #8510 |
|
The old PR is #7925 |
matthewmcneely
previously approved these changes
Jan 5, 2023
mangalaman93
force-pushed
the
aman/restoreTs
branch
from
05bae0f
to
0985b36
Compare
mangalaman93
requested review from
skrdgraph,
darkn3rd,
meghalims and
billprovince
as code owners
mangalaman93
force-pushed
the
aman/lock
branch
from
5e54ae7
to
8370194
Compare
mangalaman93
force-pushed
the
aman/restoreTs
branch
from
0985b36
to
8c8102e
Compare
mangalaman93
force-pushed
the
aman/lock
branch
from
8370194
to
f360e67
Compare
mangalaman93
force-pushed
the
aman/restoreTs
branch
from
8c8102e
to
c129021
Compare
mangalaman93
force-pushed
the
aman/lock
branch
from
f360e67
to
109e98f
Compare
mangalaman93
force-pushed
the
aman/restoreTs
branch
from
c129021
to
b7c2cdd
Compare
mangalaman93
force-pushed
the
aman/lock
branch
from
109e98f
to
417d31e
Compare
skrdgraph
previously approved these changes
Feb 1, 2023
mangalaman93
force-pushed
the
aman/restoreTs
branch
from
b7c2cdd
to
cbe1a11
Compare
mangalaman93
force-pushed
the
aman/lock
branch
from
417d31e
to
f0b4621
Compare
mangalaman93
force-pushed
the
aman/restoreTs
branch
from
cbe1a11
to
7f72777
Compare
mangalaman93
dismissed stale reviews from skrdgraph and matthewmcneely
via
f0b4621
Earlier the admin server mutex lock was used to protect the graphql schema map. But now we store that in schema store that internally handles the concurrency. Hence, we don't need to take the admin server's read lock to access schema. /probe/graphql is used as health check and is called very frequently. This rlock on adminserver mutex makes the /probe/graphql requests block while lazy loading when restore operation gets triggered at the startup. That leads to so many go routines being spun up. (cherry picked from commit 5ad40d8)
mangalaman93
force-pushed
the
aman/lock
branch
from
f0b4621
to
2163656
Compare
harshil-goel
approved these changes
Feb 2, 2023
all-seeing-code
approved these changes
Feb 2, 2023
all-seeing-code
pushed a commit
that referenced
this pull request
Feb 8, 2023
Earlier the admin server mutex lock was used to protect the graphql schema map. But now we store that in schema store that internally handles the concurrency. Hence, we don't need to take the admin server's read lock to access schema. /probe/graphql is used as health check and is called very frequently. This rlock on adminserver mutex makes the /probe/graphql requests block while lazy loading when restore operation gets triggered at the startup. That leads to so many go routines being spun up. (cherry picked from commit 5ad40d8)
all-seeing-code
pushed a commit
that referenced
this pull request
Feb 8, 2023
Earlier the admin server mutex lock was used to protect the graphql schema map. But now we store that in schema store that internally handles the concurrency. Hence, we don't need to take the admin server's read lock to access schema. /probe/graphql is used as health check and is called very frequently. This rlock on adminserver mutex makes the /probe/graphql requests block while lazy loading when restore operation gets triggered at the startup. That leads to so many go routines being spun up. (cherry picked from commit 5ad40d8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier the admin server mutex lock was used to protect the graphql schema map. But now we store that in schema store that internally handles the concurrency. Hence, we don't need to take the admin server's read lock to access schema.
/probe/graphql is used as health check and is called very frequently. This rlock on adminserver mutex makes the /probe/graphql requests block while lazy loading when restore operation gets triggered at the startup. That leads to so many go routines being spun up.
(cherry picked from commit 5ad40d8)