Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type definitions potentially not backed up and/or restored properly. #4507

Closed
martinmr opened this issue Jan 6, 2020 · 1 comment · Fixed by #4514
Closed

Type definitions potentially not backed up and/or restored properly. #4507

martinmr opened this issue Jan 6, 2020 · 1 comment · Fixed by #4514
Assignees
@martinmr
Labels
area/enterprise/backup Related to binary backups priority/P0 Critical issue that requires immediate attention. status/accepted We accept to investigate/work on it.
Milestone
Dgraph v1.1.2

Comments

@martinmr
Copy link
Contributor

martinmr commented Jan 6, 2020

What version of Dgraph are you using?

v1.1

Have you tried reproducing the issue with the latest release?

Customer noticed that the schema definitions are restored but the type definitions do not appear in Ratel. Schema queries return the expected data but type schema queries return an empty result. I still need to reproduce the issue on my side.

Steps to reproduce the issue (command/config used to run Dgraph).

N/A

Expected behaviour and actual result.

Types and schema are backed up and restored.
@martinmr martinmr self-assigned this Jan 6, 2020
@martinmr
Copy link
Contributor Author

martinmr commented Jan 7, 2020

I was able to confirm this is a bug. Types are not being backed up. Fix is in the way.

@martinmr martinmr added area/enterprise/backup Related to binary backups priority/P0 Critical issue that requires immediate attention. status/accepted We accept to investigate/work on it. labels Jan 7, 2020
@martinmr martinmr mentioned this issue Jan 7, 2020
Merged
martinmr added a commit that referenced this issue Jan 8, 2020
@martinmr
Backup types (#4514)
261ac8e 
Types were not being properly backed up. This PR fixes the bug and changes the test to verify types and predicates appear in the restored backup.

Fixes #4507
danielmai pushed a commit that referenced this issue Jan 12, 2020
@martinmr @danielmai
Backup types (#4514)
051da7a 
Types were not being properly backed up. This PR fixes the bug and changes the test to verify types and predicates appear in the restored backup.

Fixes #4507

(cherry picked from commit 261ac8e)
@sleto-it sleto-it added this to the Dgraph v1.1.2 milestone Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinmr martinmr

Labels
area/enterprise/backup Related to binary backups priority/P0 Critical issue that requires immediate attention. status/accepted We accept to investigate/work on it.
Milestone
Dgraph v1.1.2
Development

Successfully merging a pull request may close this issue.

Backup types dgraph-io/dgraph
2 participants
@martinmr @sleto-it