Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix merging inertials with mass 0 #357

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Fix merging inertials with mass 0 #357

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5c80ab
Fix merging inertials with mass 0 #349
AlpenAalAlex Mar 13, 2024
ad53079
Fix - Weighing objects by volume if mass totals 0
AlpenAalAlex Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion phobos/blender/model/inertia.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,13 @@ def combine_com_3x3(objects):
for obj in objects:
combined_com = combined_com + obj.matrix_local.translation * obj['mass']
combined_mass += obj['mass']
combined_com = combined_com / combined_mass
if combined_mass != 0:
combined_com = combined_com / combined_mass
else:
combined_com = mathutils.Vector((0.0,) * 3)
for obj in objects:
combined_com = combined_com + obj.matrix_local.translation
log(message=f"Inertial {objects[0].name} exported with mass 0")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way you put the else part the combined_com will be somewhere outside the objects. If there is now mass we should take the center of volumes. Therefore the obj.matrix_local.translation should be weighted with the volume off the obj (convex hull if not watertight).

log(" Combined center of mass: " + str(combined_com), 'DEBUG')
return combined_mass, combined_com

Expand Down