Fix merging inertials with mass 0 #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assuming every inertial has the same mass if their mass is 0 in total
hwiedPro
reviewed
May 16, 2024
phobos/blender/model/inertia.py
Outdated
| combined_com = mathutils.Vector((0.0,) * 3) | ||
| for obj in objects: | ||
| combined_com = combined_com + obj.matrix_local.translation | ||
| log(message=f"Inertial {objects[0].name} exported with mass 0") |
There was a problem hiding this comment.
The way you put the else part the combined_com will be somewhere outside the objects. If there is now mass we should take the center of volumes. Therefore the obj.matrix_local.translation should be weighted with the volume off the obj (convex hull if not watertight).
|
Thanks for your changes, @AlpenAalAlex , this looks fine to me now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On export we calculate the center of mass of all inertials of an object. This fails if their mass totals 0. In this case this PR uses their center as center of mass.
Related Issue
#349
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: