Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #346

Closed
wants to merge 21 commits into from
Closed

Develop #346

wants to merge 21 commits into from

Conversation

hwiedPro
Copy link
Collaborator

The develop branch contains several fixes for issues.
And some further fixes that I noticed.

Description

Related Issue

#331
#339
...

How Has This Been Tested?

@AlpenAalAlex Could you check whether the changes work for you too?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

Copy link
Collaborator

@AlpenAalAlex AlpenAalAlex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The export looked like this for me. I think the IMU is missing a pose.

<sensor name="imuman" type="imu">
  <always_on>1</always_on>
  <visualize>0</visualize>
  <enable_metrics>0</enable_metrics>
</sensor>

Copy link
Collaborator

@AlpenAalAlex AlpenAalAlex Feb 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no /bin/bash executable under Windows. I think for Windows phobos/utils/misc.py line 152 has to look like this:
proc = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, shell=True, cwd=cwd)

@david-wb
Copy link

david-wb commented Mar 8, 2024

The sdf export is broken for me on this branch. The <link>s elements are missing.

@hwiedPro
Copy link
Collaborator Author

Closing this in favor of #364

@hwiedPro hwiedPro closed this Jun 13, 2024
@hwiedPro
Copy link
Collaborator Author

The sdf export is broken for me on this branch. The <link>s elements are missing.

@david-wb Thanks for your test. Would you be so kind to check with the pre_v2.1.0 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants