-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: upgrade agent-js v2 #5274
Conversation
# Conflicts: # frontend/package-lock.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
@dskloetd, could you please review the pr, since you haven't committed to it? |
Can you update the PR description to describe the current state of the PR? |
@dskloetd, upgraded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks guyz! |
This reverts commit eaf3336.
Motivation
Upgrade all required dependencies to support agent-js v2.
Changes
new HttpAgent(options)
with an async version, because the constructor is deprecated - https://github.com/dfinity/agent-js/releases.ic-js
to the upgraded to the agent-js v2 version.Tests
@dfinity/utils
. This is done to avoidagent-js
to make a real network requests. In version 2.0,agent-js
starts syncing time with the replica immediately after creation, which breaks some tests since real fetch requests are not allowed.Error sample:
Todos