-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: agent-js v2.0.0 #679
Conversation
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
size-limit report 📦
|
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
Will this require changes in nns-dapp when we update the ic-js deps in nns-dapp? |
Let me put it in draft and I do some testing first. I don't think it will require changes in NNS dapp. |
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
Indeed does not require any particular changes in NNS dapp except adapt the agent similarly as in this PR in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Motivation
Bump agent-js v2.0.0 (release notes) and update
HttpAgent
creation accordingly.Changes
npm run update:agent
HttpAgent.create
in thecreateAgent
which per extension also improve the creation of the agent by also callingsyncTime
defaultAgent
simply replace contructor call with synchronousHttpAgent.createSync