build: upgrade next and ic-management #2805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterpeterparker
changed the title
3 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 3, 2023
# Motivation Add support for CreateServiceNervousSystem proposal. Proposal style changes will come in a separate pr. - [x] Related `ic-js` pr dfinity/ic-js#369 - [x] Upgrade `ic-js` in `nns-dapp` (done in [pr](#2805)) # Changes - add CreateServiceNervousSystem labels - extend `Json` component to render base_64 images. # Tests - `fromDefinedNullableRecursive` - `Json` renders images # Todos - [x] Add entry to changelog (if necessary). # Screenshots  ## Payload 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Bump ic-js to next after release of ic-js v0.0.18.
Implement the usage of the
@dfinity/ic-managementlibrary because the definition in agent-js is not up-to-date anymore and ship a fix to use this library locally.PRs