Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1 proposal support #369

Merged
merged 17 commits into from
Jun 30, 2023
Merged

1 proposal support #369

merged 17 commits into from
Jun 30, 2023

Conversation

mstrasinskis
Copy link
Contributor

@mstrasinskis mstrasinskis commented Jun 30, 2023 •
edited
Loading

Motivation

Add CreateServiceNervousSystem <-> RawCreateServiceNervousSystem transformations.

Required for nns-dapp pr.

Changes

  • add all related transform functions

Tests

  • Manually compared that after RawCreateServiceNervousSystem to CreateServiceNervousSystem transformation all fields and values match.

Screenshot

Before After
image
image		 image

@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2023 •
edited
Loading

size-limit report 📦

Path Size
@dfinity/ckbtc 7.84 KB (0%)
@dfinity/cmc 998 B (0%)
@dfinity/ledger 2.13 KB (0%)
@dfinity/nns 30.26 KB (+4.65% 🔺)
@dfinity/nns-proto 76.3 KB (0%)
@dfinity/sns 13.39 KB (0%)
@dfinity/utils 3.71 KB (0%)
@dfinity/rosetta-client -19 B (0%)
@dfinity/ic-management 1.91 KB (0%)

@mstrasinskis mstrasinskis mentioned this pull request Jun 30, 2023
Merged
3 tasks
@mstrasinskis mstrasinskis marked this pull request as ready for review June 30, 2023 14:28
lmuntaner
lmuntaner approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you!! That was probably painful and cumbersome to write!

@mstrasinskis mstrasinskis enabled auto-merge (squash) June 30, 2023 15:17
@mstrasinskis mstrasinskis merged commit 545db81 into main Jun 30, 2023
@mstrasinskis mstrasinskis deleted the 1-proposal-support branch June 30, 2023 19:24
github-merge-queue bot pushed a commit to dfinity/nns-dapp that referenced this pull request Jul 3, 2023
@mstrasinskis
1 proposal basic rendering (#2753)
8c4ede3 
# Motivation

Add support for CreateServiceNervousSystem proposal. Proposal style
changes will come in a separate pr.

- [x] Related `ic-js` pr  dfinity/ic-js#369
- [x] Upgrade `ic-js` in `nns-dapp` (done in
[pr](#2805))

# Changes

- add CreateServiceNervousSystem labels
- extend `Json` component to render base_64 images.

# Tests

- `fromDefinedNullableRecursive`
- `Json` renders images

# Todos

- [x] Add entry to changelog (if necessary).

# Screenshots


![image](https://github.com/dfinity/nns-dapp/assets/98811342/d7ca7184-29d9-4093-a769-d934fc45b97f)

## Payload

![image](https://github.com/dfinity/nns-dapp/assets/98811342/2dad9709-9a37-4408-99ce-de2c5b22d1ec)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmuntaner lmuntaner lmuntaner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mstrasinskis @lmuntaner