chore: duplicate btc header validation to main repo #769
Conversation
There was a problem hiding this comment.
I'm not too fond of duplicating & vendoring an entire crate -- especially since we own it. Can you clarify the concrete issues you're running into here? Why can't the bitcoin-canister repo upgrade its bitcoin dep?
There was a problem hiding this comment.
Can you add context about where this crate comes from?
There was a problem hiding this comment.
We can't use it because the ic-btc-validation uses types from the old bitcoin crate as part of it's interface.
It is temporary duplication. I need to merge this one and then I will dedup the bitcoin external crate dependency.
|
Thank you for contributing! Unfortunately this repository does not accept external contributions yet. We are working on enabling this by aligning our internal processes and our CI setup to handle external contributions. However this will take some time to set up so in the meantime we unfortunately have to close this Pull Request. We hope you understand and will come back once we accept external PRs. — The DFINITY Foundation""" |
|
Thank you for contributing! Unfortunately this repository does not accept external contributions yet. We are working on enabling this by aligning our internal processes and our CI setup to handle external contributions. However this will take some time to set up so in the meantime we unfortunately have to close this Pull Request. We hope you understand and will come back once we accept external PRs. — The DFINITY Foundation""" |
|
Thank you for contributing! Unfortunately this repository does not accept external contributions yet. We are working on enabling this by aligning our internal processes and our CI setup to handle external contributions. However this will take some time to set up so in the meantime we unfortunately have to close this Pull Request. We hope you understand and will come back once we accept external PRs. — The DFINITY Foundation""" |
Copies validation from the bitcoin-canister [repo](https://github.com/dfinity/bitcoin-canister). This is done to decouple the repos such that, for example, the bitcoin crate can be updated independently. --------- Co-authored-by: Tim Gretler <tim.gretler@dfinity.org> Co-authored-by: IDX GitHub Automation <infra+github-automation@dfinity.org>
Copies validation from the bitcoin-canister repo. This is done to decouple the repos such that, for example, the bitcoin crate can be updated independently.