Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: duplicate btc header validation to main repo #769 #1766

Merged
merged 22 commits into from
Oct 2, 2024

Conversation

rumenov
Copy link
Member

@rumenov rumenov commented Oct 1, 2024

Copies validation from the bitcoin-canister repo. This is done to decouple the repos such that, for example, the bitcoin crate can be updated independently.

@rumenov rumenov changed the title Rumenov/tim/btc bump chore: duplicate btc header validation to main repo #769 Oct 1, 2024
@github-actions github-actions bot added the chore label Oct 1, 2024
@rumenov rumenov marked this pull request as ready for review October 1, 2024 10:55
@rumenov rumenov requested review from a team as code owners October 1, 2024 10:55
Copy link
Member

@fspreiss fspreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code in rs/bitcoin/validation should be owned by somebody (other than the interface-owners, to whom ownership currently falls back): given that the source from which this is copied is owned by the Execution team, likely rs/bitcoin/validation should also be owned by them.

@rumenov rumenov requested a review from a team as a code owner October 2, 2024 07:43
@rumenov
Copy link
Member Author

rumenov commented Oct 2, 2024

The code in rs/bitcoin/validation should be owned by somebody (other than the interface-owners, to whom ownership currently falls back): given that the source from which this is copied is owned by the Execution team, likely rs/bitcoin/validation should also be owned by them.

Good point, I updated the codeowners file to share the onwership. However, in followup MRs I do plan to merge the validation directly into the adapter and slim it down.

@rumenov rumenov requested a review from fspreiss October 2, 2024 07:44
@rumenov rumenov enabled auto-merge October 2, 2024 12:39
@rumenov rumenov requested review from DSharifi, marko-k0, basvandijk and a team October 2, 2024 12:40
@rumenov rumenov added this pull request to the merge queue Oct 2, 2024
Merged via the queue into master with commit 6ed8636 Oct 2, 2024
30 checks passed
@rumenov rumenov deleted the rumenov/tim/btc-bump branch October 2, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants