-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: duplicate btc header validation to main repo #769 #1766
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code in rs/bitcoin/validation
should be owned by somebody (other than the interface-owners, to whom ownership currently falls back): given that the source from which this is copied is owned by the Execution team, likely rs/bitcoin/validation
should also be owned by them.
Good point, I updated the codeowners file to share the onwership. However, in followup MRs I do plan to merge the validation directly into the adapter and slim it down. |
Copies validation from the bitcoin-canister repo. This is done to decouple the repos such that, for example, the bitcoin crate can be updated independently.