Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update IC commit with voting_power_refreshed_timestamp_seconds #747

Merged
merged 5 commits into from
Nov 4, 2024
Merged

Update IC commit with voting_power_refreshed_timestamp_seconds #747

merged 5 commits into from
Nov 4, 2024

Conversation

dskloetd
Copy link
Collaborator

@dskloetd dskloetd commented Nov 4, 2024

Motivation

The automatic candid update failed because of a new neuron field: voting_power_refreshed_timestamp_seconds.

Changes

  1. Ran ./scripts/import-candid ../../ic and ./scripts/compile-idl-js.
  2. Added conversions for voting_power_refreshed_timestamp_seconds.
  3. Added empty mock values for voting_power_refreshed_timestamp_seconds.

Tests

Added unit tests for converting voting_power_refreshed_timestamp_seconds.

Todos

  • Add entry to changelog (if necessary).

@dskloetd dskloetd marked this pull request as ready for review November 4, 2024 08:48
@dskloetd dskloetd requested review from a team as code owners November 4, 2024 08:48
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024 •
edited
Loading

size-limit report 📦

Path Size
@dfinity/ckbtc 8.02 KB (0%)
@dfinity/cketh 3.58 KB (+0.25% 🔺)
@dfinity/cmc 1.4 KB (0%)
@dfinity/ledger-icrc 4.17 KB (0%)
@dfinity/ledger-icp 15.43 KB (0%)
@dfinity/nns 36.64 KB (+0.13% 🔺)
@dfinity/nns-proto 140.98 KB (0%)
@dfinity/sns 16.66 KB (+2.92% 🔺)
@dfinity/utils 4.64 KB (0%)
@dfinity/ic-management 3.02 KB (+0.36% 🔺)

mstrasinskis
mstrasinskis approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@dskloetd dskloetd enabled auto-merge (squash) November 4, 2024 10:07
@dskloetd dskloetd merged commit c2d45a4 into main Nov 4, 2024
11 checks passed
@dskloetd dskloetd deleted the kloet/bump-2024-10-31 branch November 4, 2024 10:09
@dskloetd dskloetd mentioned this pull request Nov 4, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstrasinskis mstrasinskis mstrasinskis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dskloetd @mstrasinskis