Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Candid Files #746

Closed
wants to merge 1 commit into from
Closed

Update Candid Files #746

wants to merge 1 commit into from

Conversation

sa-github-api
Copy link
Collaborator

Motivation

The canisters APIs have been updated.

Changes

  • Updated the candid interface files for the canisters used in this library.
  • Updated the javascript bindings for the latest candid interfaces.

Tests

  • Please check the API updates for any breaking changes that affect our code.

@sa-github-api sa-github-api requested review from a team as code owners November 4, 2024 03:37
dskloetd added a commit that referenced this pull request Nov 4, 2024
# Motivation

The [automatic candid update](#746)
failed because of a new neuron field:
`voting_power_refreshed_timestamp_seconds`.

# Changes

1. Ran `./scripts/import-candid ../../ic` and
`./scripts/compile-idl-js`.
2. Added conversions for `voting_power_refreshed_timestamp_seconds`.
3. Added empty mock values for
`voting_power_refreshed_timestamp_seconds`.

# Tests

Added unit tests for converting
`voting_power_refreshed_timestamp_seconds`.

# Todos

- [x] Add entry to changelog (if necessary).
@dskloetd
Copy link
Collaborator

dskloetd commented Nov 4, 2024

Fixed by #747

@dskloetd dskloetd closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants