Remove unused stakeNeuronIcrc1 #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dskloetd
force-pushed
the
kloet/rm-icrc1-stake
branch
from
b0a91d0
to
49629f7
Compare
size-limit report 📦
|
mstrasinskis
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
stakeNeuronIcrc1was originally added because transferring with ICRC-1 avoids having to calculate the subaccount identifier using a 3rd party hashing libaray.Unfortunately, ICRC-1 memos are not compatible with ICP ledger memos so we ended up never using this function.
Ideally we would implement ICRC-2 in the governance canister and use that. But that hasn't happened yet.
Changes
Remove unused
stakeNeuronIcrc1function.Tests
Removed.
Todos