-
Notifications
You must be signed in to change notification settings - Fork 16
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove unused stakeNeuronIcrc1 (#742)
# Motivation `stakeNeuronIcrc1` was originally added because transferring with ICRC-1 avoids having to calculate the subaccount identifier using a 3rd party hashing libaray. Unfortunately, ICRC-1 memos are not compatible with ICP ledger memos so we ended up never using this function. Ideally we would implement ICRC-2 in the governance canister and use that. But that hasn't happened yet. # Changes Remove unused `stakeNeuronIcrc1` function. # Tests Removed. # Todos - [x] Add entry to changelog (if necessary).
- Loading branch information
Showing
4 changed files
with
31 additions
and
231 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,9 @@ | ||
# 2024.xx.yy-hhmmZ | ||
|
||
# Breaking changes | ||
|
||
- Remove `stakeNeuronIcrc1`. | ||
|
||
# 2024.10.29-1130Z | ||
|
||
## Overview | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.