#100: implement repository commandlet #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salimbouch
commented
Nov 15, 2023
cli/src/main/java/com/devonfw/tools/ide/commandlet/RepositoryCommandlet.java
Outdated
Show resolved
Hide resolved
hohwille
requested changes
Dec 11, 2023
There was a problem hiding this comment.
@salimbouch thanks for your PR. You integrated the feature properly in the right code places and your approach looks fine 👍
I added several review comments for improvement. Please have a look.
cli/src/main/java/com/devonfw/tools/ide/commandlet/RepositoryCommandlet.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/commandlet/RepositoryCommandlet.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/commandlet/RepositoryCommandlet.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/commandlet/RepositoryCommandlet.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/commandlet/RepositoryCommandlet.java
Outdated
Show resolved
Hide resolved
hohwille
reviewed
Dec 11, 2023
…ommandlet.java Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
hohwille
reviewed
Mar 12, 2024
cli/src/main/java/com/devonfw/tools/ide/commandlet/RepositoryCommandlet.java
Show resolved
Hide resolved
hohwille
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
@salimbouch thanks for your rework and maintaining the feature-branch with all the conflict resolutions.
This now seems fine to me and can be merged.
I left some comments. If you have some time to accept the proposals and maybe even improve on the last suggestion this would be great. I would merge this on Thursday. If you don't address the last point till then, I can merge it and we can still improve this in a separate PR after merge.
cli/src/main/java/com/devonfw/tools/ide/property/RepositoryProperty.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/property/RepositoryProperty.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/commandlet/RepositoryCommandlet.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/commandlet/RepositoryCommandlet.java
Outdated
Show resolved
Hide resolved
…perty.java Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
…perty.java Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
…ommandlet.java Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
…lement-repository-commandlet
…com/salimbouch/IDEasy into 100-implement-repository-commandlet
…com/salimbouch/IDEasy into 100-implement-repository-commandlet
hohwille
added
the
story-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #100