IDEasy not cloning active repositories from devonfw-ide legacy settings

[hohwille]

Expected behavior

As a IDEasy user, I want to work with my devonfw-ide project or upgrade-settings to IDEasy so that it works like with devonfw-ide and I do not have to worry about incompatibilities.

Actual behavior

Invalid repository configuration xyz.properties - both 'path' and 'git-url' have to be defined.

Steps to reproduce (bug) / Use Case of feature request (enhancement)

1. ide create myproject «url-of-devonfw-ide-settings-project-with-active-project-repository»

Related/Dependent Issues

Story #100, PR #143

Implemented like this:

IDEasy/cli/src/main/java/com/devonfw/tools/ide/commandlet/RepositoryConfig.java

Line 61 in 3a24512

properties.getProperty("workspace"), properties.getProperty("git_url"), properties.getProperty("git_branch"),

Correctly as documented in devonfw-ide and doc was linked from the story.

Bute there is something I missed:
https://github.com/devonfw/ide/blob/8698d2ba7468d34aec82c86fabdb09b5ee84d9c8/scripts/src/main/resources/scripts/functions-core#L41

When devonfw-ide started, a dot was used as separator (git.url).
Later properties were loaded into bash variables and those variables cannot have a dot in the name.
So we replaced the dot with an underscore.
All projects that started earlier were using git.url and git.branch instead of git_url and git_branch.
See here as a proof:
https://github.com/devonfw/ide-settings/blob/4214b9dca2b3d5efdcbf8e60cb62617cc90f2f9f/projects/devon4j.properties

Comments/Hints:

1. We need to add compatibility support in RepositoryConfig to fallback to the property names with dots.
2. We IMHO should improve #759: upgrade settings commandlet #820 to migrate these properties from dot to underscores, since this is the officially specified format according to our documentation.

Affected version:

• 2024.12.002-beta

[hohwille]

This issue was caused because devonfw-ide was supporting alternative notations of the same property such as git_url or git-url.
In IDEasy initially only the notation with underscores was implemented and therefore git-url was not recognized and change was needed to git_url.
However, already quite some time ago this was already fixed and is now supported:

IDEasy/cli/src/main/java/com/devonfw/tools/ide/git/repository/RepositoryProperties.java

Lines 58 to 70 in bbe3a82

	public String getProperty(String name, boolean required) {
	String value = this.properties.getProperty(name);
	if (value == null) {
	String legacyName = name.replace("_", ".");
	if (!legacyName.equals(name)) {
	value = getLegacyProperty(legacyName, name);
	if (value == null) {
	legacyName = name.replace("_", "-");
	value = getLegacyProperty(legacyName, name);
	}
	}
	}

In other words this issue was already fixed without noticing and hence the issue was not closed. I am closing it now.