-
Notifications
You must be signed in to change notification settings - Fork 93
Bump up registry go version to 1.23 and odo to 3.16.1 #611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jdubrick, michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of Changes
Bumps up the tests of the registry to go version 1.23 as that the UBI8 go-toolset has no tag on 1.24 only 1.23.
See: https://catalog.redhat.com/software/containers/ubi8/go-toolset/5ce8713aac3db925c03774d1
Additionally, as shared by the odo team the odo nightly builds are no longer supported, thus the current PR uses the newest version of odo (3.16.1) which includes the support for devfile versions 2.2.1 & 2.2.2
Related Issue(s)
Fixes devfile/api#1697
Fixes devfile/api#1714
Acceptance Criteria
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
Tests Performed
Explain what tests you personally ran to ensure the changes are functioning as expected.
How To Test
Instructions for the reviewer on how to test your changes.
Notes To Reviewer
Any notes you would like to include for the reviewer.