Skip to content

fix: changed lt(exclusiveMaximum) to le(maximum) for DEM algorithms #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2024
Merged

fix: changed lt(exclusiveMaximum) to le(maximum) for DEM algorithms #797

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/titiler/core/titiler/core/algorithm/dem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ class HillShade(BaseAlgorithm):
description: str = "Create hillshade from DEM dataset."

# parameters
azimuth: int = Field(90, ge=0, lt=360)
angle_altitude: float = Field(90.0, ge=-90.0, lt=90.0)
buffer: int = Field(3, ge=0, lt=99)
azimuth: int = Field(90, ge=0, le=360)
angle_altitude: float = Field(90.0, ge=-90.0, le=90.0)
buffer: int = Field(3, ge=0, le=99)

# metadata
input_nbands: int = 1
Expand Down Expand Up @@ -69,10 +69,10 @@ class Contours(BaseAlgorithm):
description: str = "Create contours from DEM dataset."

# parameters
increment: int = Field(35, ge=0, lt=999)
thickness: int = Field(1, ge=0, lt=10)
minz: int = Field(-12000, ge=-99999, lt=99999)
maxz: int = Field(8000, ge=-99999, lt=99999)
increment: int = Field(35, ge=0, le=999)
thickness: int = Field(1, ge=0, le=10)
minz: int = Field(-12000, ge=-99999, le=99999)
maxz: int = Field(8000, ge=-99999, le=99999)

# metadata
input_nbands: int = 1
Expand Down Expand Up @@ -136,8 +136,8 @@ class TerrainRGB(BaseAlgorithm):
description: str = "Encode DEM into RGB (Mapbox Terrain RGB)."

# parameters
interval: float = Field(0.1, ge=0.0, lt=1.0)
baseval: float = Field(-10000.0, ge=-99999.0, lt=99999.0)
interval: float = Field(0.1, ge=0.0, le=1.0)
baseval: float = Field(-10000.0, ge=-99999.0, le=99999.0)

# metadata
input_nbands: int = 1
Expand Down