fix: changed lt(exclusiveMaximum) to le(maximum) for DEM algorithms #797
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vincentsarago I am sorry, I did a mistake for maximum value setting for DEM algorithms. It should be
le (maximum)instead oflt (exclusiveMaximum).I fixed them, and the new response of
/algorithmsendpoint is shown below/algorithms endpoint response
{ "hillshade":{ "title":"Hillshade", "description":"Create hillshade from DEM dataset.", "inputs":{ "nbands":1 }, "outputs":{ "nbands":1, "dtype":"uint8", "min":null, "max":null }, "parameters":{ "azimuth":{ "default":90, "maximum":360, "minimum":0, "title":"Azimuth", "type":"integer" }, "angle_altitude":{ "default":90, "maximum":90, "minimum":-90, "title":"Angle Altitude", "type":"number" }, "buffer":{ "default":3, "maximum":99, "minimum":0, "title":"Buffer", "type":"integer" } } }, "contours":{ "title":"Contours", "description":"Create contours from DEM dataset.", "inputs":{ "nbands":1 }, "outputs":{ "nbands":3, "dtype":"uint8", "min":null, "max":null }, "parameters":{ "increment":{ "default":35, "maximum":999, "minimum":0, "title":"Increment", "type":"integer" }, "thickness":{ "default":1, "maximum":10, "minimum":0, "title":"Thickness", "type":"integer" }, "minz":{ "default":-12000, "maximum":99999, "minimum":-99999, "title":"Minz", "type":"integer" }, "maxz":{ "default":8000, "maximum":99999, "minimum":-99999, "title":"Maxz", "type":"integer" } } }, "normalizedIndex":{ "title":"Normalized Difference Index", "description":"Compute normalized difference index from two bands.", "inputs":{ "nbands":2 }, "outputs":{ "nbands":1, "dtype":"float32", "min":[ -1 ], "max":[ 1 ] }, "parameters":{ } }, "terrarium":{ "title":"Terrarium", "description":"Encode DEM into RGB (Mapzen Terrarium).", "inputs":{ "nbands":1 }, "outputs":{ "nbands":3, "dtype":"uint8", "min":null, "max":null }, "parameters":{ } }, "terrainrgb":{ "title":"Terrarium", "description":"Encode DEM into RGB (Mapbox Terrain RGB).", "inputs":{ "nbands":1 }, "outputs":{ "nbands":3, "dtype":"uint8", "min":null, "max":null }, "parameters":{ "interval":{ "default":0.1, "maximum":1, "minimum":0, "title":"Interval", "type":"number" }, "baseval":{ "default":-10000, "maximum":99999, "minimum":-99999, "title":"Baseval", "type":"number" } } } }