perf: Remove typedArrayManager settings override #1003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 29, 2025
kylebarron
added a commit
that referenced
this pull request
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #917 I documented some performance issues during rendering.
Removing these settings for
typedArrayManagerPropsfixes the rendering performance.The issue is that we were never using deck.gl to allocate data before this layer. So I essentially turned off the typed array manager to avoid any extra memory usage.
But with the H3Layer, we're now passing h3 strings to deck.gl and letting deck.gl manage the geometry construction. This means that with the typed array manager turned off we were getting massive performance hits to allocations and GC.
Also improves perf of the upcoming A5Layer
cc @felixpalmer