Skip to content

Commit 944f4ea

Browse files
authored
perf: Remove typedArrayManager settings override (#1003)
In #917 I documented some performance issues during rendering. Removing these settings for `typedArrayManagerProps` fixes the rendering performance. The issue is that we were never using deck.gl to allocate data before this layer. So I essentially turned off the typed array manager to avoid any extra memory usage. But with the H3Layer, we're now passing h3 strings to deck.gl and letting deck.gl manage the geometry construction. This means that with the typed array manager turned off we were getting massive performance hits to allocations and GC. Also improves perf of the [upcoming A5Layer](#1001) cc @felixpalmer
1 parent a2924a2 commit 944f4ea

File tree

2 files changed

+1
-13
lines changed

2 files changed

+1
-13
lines changed

src/renderers/deck-first.tsx

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,6 @@ const DeckFirstRenderer: React.FC<MapRendererProps & DeckFirstRendererProps> = (
2929
ref={deckRef}
3030
style={{ width: "100%", height: "100%" }}
3131
controller={true}
32-
// https://deck.gl/docs/api-reference/core/deck#_typedarraymanagerprops
33-
_typedArrayManagerProps={{
34-
overAlloc: 1,
35-
poolSize: 0,
36-
}}
3732
{...deckProps}
3833
>
3934
{controls.map((control) => control.renderDeck())}

src/renderers/overlay.tsx

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -47,14 +47,7 @@ const OverlayRenderer: React.FC<MapRendererProps & OverlayRendererProps> = (
4747
{...(isGlobeView(views) && { projection: "globe" })}
4848
>
4949
{controls.map((control) => control.renderMaplibre())}
50-
<DeckGLOverlay
51-
// https://deck.gl/docs/api-reference/core/deck#_typedarraymanagerprops
52-
_typedArrayManagerProps={{
53-
overAlloc: 1,
54-
poolSize: 0,
55-
}}
56-
{...deckProps}
57-
/>
50+
<DeckGLOverlay {...deckProps} />
5851
</Map>
5952
);
6053
};

0 commit comments

Comments
 (0)