-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deployment information to mkdocs, and reference eoapi-template. #114
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d9c2e73
Add deployment information to mkdocs, and reference eoapi-template.
zacharyDez 9f5993d
Fix path to eoAPI logo
zacharyDez 5ef4f58
Reduce intro.md to limited information on getting started.
zacharyDez e4a08f4
Rename k8s-eoapi to eoapi-k8s to match renaming of repository name
zacharyDez 8e17e8c
Revert intro.md to the state before this branch (749b85dc1d4568969dcd…
zacharyDez 106135c
Update README.md
vincentsarago File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should really explain clearly what are the option for deploying an eoAPI like system.
right now this page
deployment.md
is a mix of two things:how to
to deploy eoapi custom demo applicationIMO this is really confusing.
Possible solution
eoapi-docs
repo to host all the documentation about eoapieaopi
repo as an example of how eoapi can workcc @sharkinsspatial @zacharyDez
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just renamed the repo to
eoapi-k8s
so that will have to change tooThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vincentsarago We can also just remove the external references if you prefer, but I thought it would be helpful for someone interested in deployment to have this information readily available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ranchodeluxe updated the name references to the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vincentsarago I agree this is confusing. Ideally I think the eoAPI repo would have 3 deployment sections
eoapi-cdk
,eoapi-cdk
andeoapi-template
and pointers to their docs for deploying with the default runtimes they contain.eoapi-template
) that uses theeoapi-cdk
constructs but with runtime overrides.I think this is what @zacharyDez was shooting for with his PR but based on your feedback maybe we need a bit more clarification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sharkinsspatial yep that's it on point!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it! Will go for another iteration.