Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deployment information to mkdocs, and reference eoapi-template. #114

Merged
merged 6 commits into from
Jul 18, 2023

Conversation

zacharyDez
Copy link
Contributor

Closes #113

Based on @sharkinsspatial recommendations:

  • Added reference to eoAPI-template
  • Updated mkdocs/intro to match README

@zacharyDez zacharyDez added the documentation Improvements or additions to documentation label Jul 17, 2023
@zacharyDez zacharyDez self-assigned this Jul 17, 2023
docs/src/intro.md Outdated Show resolved Hide resolved
Inverse deployment and contributing in headers/footers within mkdocs.yml. Add eoapi-template reference to deployment.md. Reduce content in intro.md to match previous version.
The default runtimes are available through separate repositories ([eoapi-cdk](https://github.com/developmentseed/eoapi-cdk) and [k8s-eoapi](https://github.com/developmentseed/k8s-eoapi)).

A demonstration application is accessible with the repository [eoapi-template](https://github.com/developmentseed/eoapi-template).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should really explain clearly what are the option for deploying an eoAPI like system.

right now this page deployment.md is a mix of two things:

  • links to external repo (eoapi-cdk and k8s-eoapi)
  • a step-by-step how to to deploy eoapi custom demo application

IMO this is really confusing.

Possible solution

  1. create an eoapi-docs repo to host all the documentation about eoapi
  2. use the current eaopi repo as an example of how eoapi can work

cc @sharkinsspatial @zacharyDez

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just renamed the repo to eoapi-k8s so that will have to change too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vincentsarago We can also just remove the external references if you prefer, but I thought it would be helpful for someone interested in deployment to have this information readily available.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ranchodeluxe updated the name references to the repo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vincentsarago I agree this is confusing. Ideally I think the eoAPI repo would have 3 deployment sections

  1. How to deploy the eoAPI demonstration runtimes locally via docker.
  2. A description of eoapi-cdk , eoapi-cdk and eoapi-template and pointers to their docs for deploying with the default runtimes they contain.
  3. How to deploy the eoAPI demonstration runtimes using a local CDK app (mostly copy and pasted from eoapi-template) that uses the eoapi-cdk constructs but with runtime overrides.

I think this is what @zacharyDez was shooting for with his PR but based on your feedback maybe we need a bit more clarification.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sharkinsspatial yep that's it on point!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it! Will go for another iteration.

docs/src/intro.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@vincentsarago vincentsarago merged commit 965f9be into main Jul 18, 2023
@vincentsarago vincentsarago deleted the docs/update-mkdocs branch July 18, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include deployment options in docs as well.
4 participants