-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deployment information to mkdocs, and reference eoapi-template. #114
Conversation
Inverse deployment and contributing in headers/footers within mkdocs.yml. Add eoapi-template reference to deployment.md. Reduce content in intro.md to match previous version.
The default runtimes are available through separate repositories ([eoapi-cdk](https://github.com/developmentseed/eoapi-cdk) and [k8s-eoapi](https://github.com/developmentseed/k8s-eoapi)). | ||
|
||
A demonstration application is accessible with the repository [eoapi-template](https://github.com/developmentseed/eoapi-template). | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should really explain clearly what are the option for deploying an eoAPI like system.
right now this page deployment.md
is a mix of two things:
- links to external repo (eoapi-cdk and k8s-eoapi)
- a step-by-step
how to
to deploy eoapi custom demo application
IMO this is really confusing.
Possible solution
- create an
eoapi-docs
repo to host all the documentation about eoapi - use the current
eaopi
repo as an example of how eoapi can work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just renamed the repo to eoapi-k8s
so that will have to change too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vincentsarago We can also just remove the external references if you prefer, but I thought it would be helpful for someone interested in deployment to have this information readily available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ranchodeluxe updated the name references to the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vincentsarago I agree this is confusing. Ideally I think the eoAPI repo would have 3 deployment sections
- How to deploy the eoAPI demonstration runtimes locally via docker.
- A description of
eoapi-cdk
,eoapi-cdk
andeoapi-template
and pointers to their docs for deploying with the default runtimes they contain. - How to deploy the eoAPI demonstration runtimes using a local CDK app (mostly copy and pasted from
eoapi-template
) that uses theeoapi-cdk
constructs but with runtime overrides.
I think this is what @zacharyDez was shooting for with his PR but based on your feedback maybe we need a bit more clarification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sharkinsspatial yep that's it on point!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it! Will go for another iteration.
Closes #113
Based on @sharkinsspatial recommendations: