feat: __add__ and __eq__ functionality in python #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitner
approved these changes
Feb 20, 2025
kylebarron
reviewed
Feb 20, 2025
| ['LC82030282019133LGN00'] | ||
| """ | ||
|
|
||
| def __add__(self, other: "Expr") -> "Expr": |
Member
There was a problem hiding this comment.
By the way you don't have to quote Expr here because you're in a pyi file
Comment on lines
+92
to
+95
|
|
||
| fn __eq__(&self, rhs: &Expr) -> bool { | ||
| self.0 == rhs.0 | ||
| } |
Member
There was a problem hiding this comment.
You also have the option of putting
#[derive(Eq)]
on the pyclass:
https://pyo3.rs/v0.23.4/class.html?highlight=partialeq#customizing-the-class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I am changing
Exprin Rust__add__and__eq__to Python